[management] Code generation: update services and models#458
[management] Code generation: update services and models#458AdyenAutomationBot wants to merge 1 commit intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request contains automated updates to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request primarily refactors Python code for improved readability and consistency by reordering import statements alphabetically and condensing multi-line function calls into single lines across various API service files. The review comments consistently suggest a minor optimization: replacing f-strings with plain string concatenation for static endpoint paths, as f-strings are redundant and slightly less efficient in these specific cases.
| Get a list of company accounts | ||
| """ | ||
| endpoint = self.baseUrl + "/companies" | ||
| endpoint = self.baseUrl + f"/companies" |
There was a problem hiding this comment.
Using an f-string for a static string like "/companies" is redundant. While not incorrect, a plain string is sufficient and slightly more efficient as it avoids unnecessary f-string processing.
| endpoint = self.baseUrl + f"/companies" | |
| endpoint = self.baseUrl + "/companies" |
| Create a merchant account | ||
| """ | ||
| endpoint = self.baseUrl + "/merchants" | ||
| endpoint = self.baseUrl + f"/merchants" |
There was a problem hiding this comment.
Using an f-string for a static string like "/merchants" is redundant. While not incorrect, a plain string is sufficient and slightly more efficient as it avoids unnecessary f-string processing.
| endpoint = self.baseUrl + f"/merchants" | |
| endpoint = self.baseUrl + "/merchants" |
| Get a list of merchant accounts | ||
| """ | ||
| endpoint = self.baseUrl + "/merchants" | ||
| endpoint = self.baseUrl + f"/merchants" |
There was a problem hiding this comment.
Using an f-string for a static string like "/merchants" is redundant. While not incorrect, a plain string is sufficient and slightly more efficient as it avoids unnecessary f-string processing.
| endpoint = self.baseUrl + f"/merchants" | |
| endpoint = self.baseUrl + "/merchants" |
| Create a store | ||
| """ | ||
| endpoint = self.baseUrl + "/stores" | ||
| endpoint = self.baseUrl + f"/stores" |
There was a problem hiding this comment.
Using an f-string for a static string like "/stores" is redundant. While not incorrect, a plain string is sufficient and slightly more efficient as it avoids unnecessary f-string processing.
| endpoint = self.baseUrl + f"/stores" | |
| endpoint = self.baseUrl + "/stores" |
| Get a list of stores | ||
| """ | ||
| endpoint = self.baseUrl + "/stores" | ||
| endpoint = self.baseUrl + f"/stores" |
There was a problem hiding this comment.
Using an f-string for a static string like "/stores" is redundant. While not incorrect, a plain string is sufficient and slightly more efficient as it avoids unnecessary f-string processing.
| endpoint = self.baseUrl + f"/stores" | |
| endpoint = self.baseUrl + "/stores" |
| Generate a client key | ||
| """ | ||
| endpoint = self.baseUrl + "/me/generateClientKey" | ||
| endpoint = self.baseUrl + f"/me/generateClientKey" |
There was a problem hiding this comment.
Using an f-string for a static string like "/me/generateClientKey" is redundant. While not incorrect, a plain string is sufficient and slightly more efficient as it avoids unnecessary f-string processing.
| endpoint = self.baseUrl + f"/me/generateClientKey" | |
| endpoint = self.baseUrl + "/me/generateClientKey" |
| Get allowed origins | ||
| """ | ||
| endpoint = self.baseUrl + "/me/allowedOrigins" | ||
| endpoint = self.baseUrl + f"/me/allowedOrigins" |
There was a problem hiding this comment.
Using an f-string for a static string like "/me/allowedOrigins" is redundant. While not incorrect, a plain string is sufficient and slightly more efficient as it avoids unnecessary f-string processing.
| endpoint = self.baseUrl + f"/me/allowedOrigins" | |
| endpoint = self.baseUrl + "/me/allowedOrigins" |
| Get API credential details | ||
| """ | ||
| endpoint = self.baseUrl + "/me" | ||
| endpoint = self.baseUrl + f"/me" |
There was a problem hiding this comment.
Using an f-string for a static string like "/me" is redundant. While not incorrect, a plain string is sufficient and slightly more efficient as it avoids unnecessary f-string processing.
| endpoint = self.baseUrl + f"/me" | |
| endpoint = self.baseUrl + "/me" |
| Create a terminal action | ||
| """ | ||
| endpoint = self.baseUrl + "/terminals/scheduleActions" | ||
| endpoint = self.baseUrl + f"/terminals/scheduleActions" |
There was a problem hiding this comment.
Using an f-string for a static string like "/terminals/scheduleActions" is redundant. While not incorrect, a plain string is sufficient and slightly more efficient as it avoids unnecessary f-string processing.
| endpoint = self.baseUrl + f"/terminals/scheduleActions" | |
| endpoint = self.baseUrl + "/terminals/scheduleActions" |
| Get a list of terminals | ||
| """ | ||
| endpoint = self.baseUrl + "/terminals" | ||
| endpoint = self.baseUrl + f"/terminals" |
There was a problem hiding this comment.
Using an f-string for a static string like "/terminals" is redundant. While not incorrect, a plain string is sufficient and slightly more efficient as it avoids unnecessary f-string processing.
| endpoint = self.baseUrl + f"/terminals" | |
| endpoint = self.baseUrl + "/terminals" |
1 participant
This PR contains the automated changes for the
managementservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.