Skip to content

[recurring] Code generation: update services and models#457

Open
AdyenAutomationBot wants to merge 1 commit intomainfrom
sdk-automation/recurring
Open

[recurring] Code generation: update services and models#457
AdyenAutomationBot wants to merge 1 commit intomainfrom
sdk-automation/recurring

Conversation

@AdyenAutomationBot
Copy link
Collaborator

This PR contains the automated changes for the recurring service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot AdyenAutomationBot requested review from a team as code owners March 20, 2026 10:37
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, generated through an automated process, updates the recurring service client by adjusting its base API endpoint URL. Additionally, it standardizes the method of constructing API endpoints within the service class by adopting f-strings, ensuring the client interacts with the correct and modern Adyen API infrastructure.

Highlights

  • API Base URL Update: Updated the base URL for the recurring service, specifically modifying the path from /pal/servlet/Recurring/v68 to /paltokenization/servlet/Recurring/v68.
  • Code Style Refinement: Refactored the construction of API endpoints within the RecurringApi class to utilize Python f-strings, enhancing readability and consistency.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@sonarqubecloud
Copy link

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the recurring service, including a change to the base URL and refactoring of endpoint construction in recurring_api.py. While the changes are functional, the new code for endpoint construction and API calls has some stylistic issues. Specifically, f-strings are used redundantly, and function calls have been formatted into single long lines, which reduces readability. I've left a comment with a suggestion to improve the code style, which should be applied to all similar instances in the file. Fixing this in the code generator would prevent similar issues in the future.

Comment on lines +22 to +24
endpoint = self.baseUrl + f"/createPermit"
method = "POST"
return self.client.call_adyen_api(
request, self.service, method, endpoint, idempotency_key, **kwargs
)
return self.client.call_adyen_api(request, self.service, method, endpoint, idempotency_key, **kwargs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There are a couple of style issues here that are repeated for each method in this file:

  1. The f-string on the string literal is redundant. It's better to use an f-string for the whole concatenation: f"{self.baseUrl}/createPermit".
  2. The call_adyen_api call is on a single long line, which harms readability. It's better to format it across multiple lines as it was before this change.

Since this is generated code, it would be best to fix the generator to produce more readable and idiomatic Python.

Suggested change
endpoint = self.baseUrl + f"/createPermit"
method = "POST"
return self.client.call_adyen_api(
request, self.service, method, endpoint, idempotency_key, **kwargs
)
return self.client.call_adyen_api(request, self.service, method, endpoint, idempotency_key, **kwargs)
endpoint = f"{self.baseUrl}/createPermit"
method = "POST"
return self.client.call_adyen_api(
request, self.service, method, endpoint, idempotency_key, **kwargs
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant