[recurring] Code generation: update services and models#457
[recurring] Code generation: update services and models#457AdyenAutomationBot wants to merge 1 commit intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, generated through an automated process, updates the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
There was a problem hiding this comment.
Code Review
This pull request updates the recurring service, including a change to the base URL and refactoring of endpoint construction in recurring_api.py. While the changes are functional, the new code for endpoint construction and API calls has some stylistic issues. Specifically, f-strings are used redundantly, and function calls have been formatted into single long lines, which reduces readability. I've left a comment with a suggestion to improve the code style, which should be applied to all similar instances in the file. Fixing this in the code generator would prevent similar issues in the future.
| endpoint = self.baseUrl + f"/createPermit" | ||
| method = "POST" | ||
| return self.client.call_adyen_api( | ||
| request, self.service, method, endpoint, idempotency_key, **kwargs | ||
| ) | ||
| return self.client.call_adyen_api(request, self.service, method, endpoint, idempotency_key, **kwargs) |
There was a problem hiding this comment.
There are a couple of style issues here that are repeated for each method in this file:
- The f-string on the string literal is redundant. It's better to use an f-string for the whole concatenation:
f"{self.baseUrl}/createPermit". - The
call_adyen_apicall is on a single long line, which harms readability. It's better to format it across multiple lines as it was before this change.
Since this is generated code, it would be best to fix the generator to produce more readable and idiomatic Python.
| endpoint = self.baseUrl + f"/createPermit" | |
| method = "POST" | |
| return self.client.call_adyen_api( | |
| request, self.service, method, endpoint, idempotency_key, **kwargs | |
| ) | |
| return self.client.call_adyen_api(request, self.service, method, endpoint, idempotency_key, **kwargs) | |
| endpoint = f"{self.baseUrl}/createPermit" | |
| method = "POST" | |
| return self.client.call_adyen_api( | |
| request, self.service, method, endpoint, idempotency_key, **kwargs | |
| ) |



This PR contains the automated changes for the
recurringservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.