[legalentitymanagement] Code generation: update services and models#456
[legalentitymanagement] Code generation: update services and models#456AdyenAutomationBot wants to merge 1 commit intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers an automated update to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces automated changes to the legalentitymanagement service, primarily focused on code formatting. The changes involve converting multi-line statements into single lines and updating string concatenations for URL endpoints. While the formatting changes are consistent, I've noticed a recurring pattern where f-strings are used unnecessarily on static strings. I have left comments with suggestions to use f-strings more idiomatically for constructing URLs, which will improve code clarity and maintainability.
| Create a business line | ||
| """ | ||
| endpoint = self.baseUrl + "/businessLines" | ||
| endpoint = self.baseUrl + f"/businessLines" |
There was a problem hiding this comment.
The f-string f"/businessLines" is unnecessary as it doesn't contain any expressions. A more idiomatic way to construct the URL would be to use a single f-string for the entire expression.
| endpoint = self.baseUrl + f"/businessLines" | |
| endpoint = f"{self.baseUrl}/businessLines" |
| Upload a document for verification checks | ||
| """ | ||
| endpoint = self.baseUrl + "/documents" | ||
| endpoint = self.baseUrl + f"/documents" |
There was a problem hiding this comment.
The f-string f"/documents" is unnecessary as it doesn't contain any expressions. A more idiomatic way to construct the URL would be to use a single f-string for the entire expression.
| endpoint = self.baseUrl + f"/documents" | |
| endpoint = f"{self.baseUrl}/documents" |
| Get a list of hosted onboarding page themes | ||
| """ | ||
| endpoint = self.baseUrl + "/themes" | ||
| endpoint = self.baseUrl + f"/themes" |
There was a problem hiding this comment.
The f-string f"/themes" is unnecessary as it doesn't contain any expressions. A more idiomatic way to construct the URL would be to use a single f-string for the entire expression.
| endpoint = self.baseUrl + f"/themes" | |
| endpoint = f"{self.baseUrl}/themes" |
| Create a legal entity | ||
| """ | ||
| endpoint = self.baseUrl + "/legalEntities" | ||
| endpoint = self.baseUrl + f"/legalEntities" |
There was a problem hiding this comment.
The f-string f"/legalEntities" is unnecessary as it doesn't contain any expressions. A more idiomatic way to construct the URL would be to use a single f-string for the entire expression.
| endpoint = self.baseUrl + f"/legalEntities" | |
| endpoint = f"{self.baseUrl}/legalEntities" |
| Create a transfer instrument | ||
| """ | ||
| endpoint = self.baseUrl + "/transferInstruments" | ||
| endpoint = self.baseUrl + f"/transferInstruments" |
There was a problem hiding this comment.
The f-string f"/transferInstruments" is unnecessary as it doesn't contain any expressions. A more idiomatic way to construct the URL would be to use a single f-string for the entire expression.
| endpoint = self.baseUrl + f"/transferInstruments" | |
| endpoint = f"{self.baseUrl}/transferInstruments" |
1 participant
This PR contains the automated changes for the
legalentitymanagementservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.