[storedvalue] Code generation: update services and models#455
[storedvalue] Code generation: update services and models#455AdyenAutomationBot wants to merge 1 commit intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates the update of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request appears to be an automated update for the storedvalue service. The changes in Adyen/services/storedValue/stored_value_api.py introduce f-strings for URL construction and reformat some method calls. While the reformatting is a minor stylistic improvement, the use of f-strings is not idiomatic. I've provided suggestions to use f-strings more effectively for building the endpoint URLs, which improves readability and consistency with the project's test code.
| Changes the status of the payment method. | ||
| """ | ||
| endpoint = self.baseUrl + "/changeStatus" | ||
| endpoint = self.baseUrl + f"/changeStatus" |
There was a problem hiding this comment.
While using an f-string is a good idea for constructing URLs, f"/changeStatus" is being used unnecessarily as it doesn't interpolate any variables. A more idiomatic and readable way to construct the endpoint URL would be to use an f-string for the entire expression. This would also align with the style seen in the test files (e.g., f"{self.stored_value_url}/issue").
| endpoint = self.baseUrl + f"/changeStatus" | |
| endpoint = f"{self.baseUrl}/changeStatus" |
| Checks the balance. | ||
| """ | ||
| endpoint = self.baseUrl + "/checkBalance" | ||
| endpoint = self.baseUrl + f"/checkBalance" |
There was a problem hiding this comment.
Similar to the comment on line 20, it's more idiomatic and readable to use a single f-string for constructing the entire URL.
| endpoint = self.baseUrl + f"/checkBalance" | |
| endpoint = f"{self.baseUrl}/checkBalance" |
| Issues a new card. | ||
| """ | ||
| endpoint = self.baseUrl + "/issue" | ||
| endpoint = self.baseUrl + f"/issue" |
There was a problem hiding this comment.
Similar to the comment on line 20, it's more idiomatic and readable to use a single f-string for constructing the entire URL.
| endpoint = self.baseUrl + f"/issue" | |
| endpoint = f"{self.baseUrl}/issue" |
| Loads the payment method. | ||
| """ | ||
| endpoint = self.baseUrl + "/load" | ||
| endpoint = self.baseUrl + f"/load" |
There was a problem hiding this comment.
Similar to the comment on line 20, it's more idiomatic and readable to use a single f-string for constructing the entire URL.
| endpoint = self.baseUrl + f"/load" | |
| endpoint = f"{self.baseUrl}/load" |
| Merge the balance of two cards. | ||
| """ | ||
| endpoint = self.baseUrl + "/mergeBalance" | ||
| endpoint = self.baseUrl + f"/mergeBalance" |
There was a problem hiding this comment.
Similar to the comment on line 20, it's more idiomatic and readable to use a single f-string for constructing the entire URL.
| endpoint = self.baseUrl + f"/mergeBalance" | |
| endpoint = f"{self.baseUrl}/mergeBalance" |
| Voids a transaction. | ||
| """ | ||
| endpoint = self.baseUrl + "/voidTransaction" | ||
| endpoint = self.baseUrl + f"/voidTransaction" |
There was a problem hiding this comment.
Similar to the comment on line 20, it's more idiomatic and readable to use a single f-string for constructing the entire URL.
| endpoint = self.baseUrl + f"/voidTransaction" | |
| endpoint = f"{self.baseUrl}/voidTransaction" |
1 participant
This PR contains the automated changes for the
storedvalueservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.