[binlookup] Code generation: update services and models#451
[binlookup] Code generation: update services and models#451AdyenAutomationBot wants to merge 1 commit intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers an automated update to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request, generated automatically, introduces some stylistic regressions. The endpoint URL construction now uses f-strings unnecessarily on static strings, which is confusing. A better approach would be to use f-strings to format the entire URL. Additionally, some function calls have been flattened into a single line, exceeding recommended line lengths and harming readability. I've added specific comments with suggestions to revert to a more readable multi-line format and use f-strings more effectively.
| Check if 3D Secure is available | ||
| """ | ||
| endpoint = self.baseUrl + "/get3dsAvailability" | ||
| endpoint = self.baseUrl + f"/get3dsAvailability" |
There was a problem hiding this comment.
The use of an f-string on a static string f"/get3dsAvailability" is unnecessary as it provides no formatting. For improved readability and to make the string formatting intention clear, it's better to format the entire URL endpoint using an f-string.
| endpoint = self.baseUrl + f"/get3dsAvailability" | |
| endpoint = f"{self.baseUrl}/get3dsAvailability" |
| return self.client.call_adyen_api( | ||
| request, self.service, method, endpoint, idempotency_key, **kwargs | ||
| ) | ||
| return self.client.call_adyen_api(request, self.service, method, endpoint, idempotency_key, **kwargs) |
There was a problem hiding this comment.
This line is over 120 characters long, which makes it difficult to read and violates common Python style guides (like PEP 8). The previous multi-line version was more readable. It's recommended to break up long lines.
| return self.client.call_adyen_api(request, self.service, method, endpoint, idempotency_key, **kwargs) | |
| return self.client.call_adyen_api( | |
| request, self.service, method, endpoint, idempotency_key, **kwargs | |
| ) |
| Get a fees cost estimate | ||
| """ | ||
| endpoint = self.baseUrl + "/getCostEstimate" | ||
| endpoint = self.baseUrl + f"/getCostEstimate" |
There was a problem hiding this comment.
The use of an f-string on a static string f"/getCostEstimate" is unnecessary as it provides no formatting. For improved readability and to make the string formatting intention clear, it's better to format the entire URL endpoint using an f-string.
| endpoint = self.baseUrl + f"/getCostEstimate" | |
| endpoint = f"{self.baseUrl}/getCostEstimate" |
| return self.client.call_adyen_api( | ||
| request, self.service, method, endpoint, idempotency_key, **kwargs | ||
| ) | ||
| return self.client.call_adyen_api(request, self.service, method, endpoint, idempotency_key, **kwargs) |
There was a problem hiding this comment.
This line is over 120 characters long, which makes it difficult to read and violates common Python style guides (like PEP 8). The previous multi-line version was more readable. It's recommended to break up long lines.
| return self.client.call_adyen_api(request, self.service, method, endpoint, idempotency_key, **kwargs) | |
| return self.client.call_adyen_api( | |
| request, self.service, method, endpoint, idempotency_key, **kwargs | |
| ) |
1 participant
This PR contains the automated changes for the
binlookupservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.