Skip to content

[payout] Code generation: update services and models#448

Open
AdyenAutomationBot wants to merge 1 commit intomainfrom
sdk-automation/payout
Open

[payout] Code generation: update services and models#448
AdyenAutomationBot wants to merge 1 commit intomainfrom
sdk-automation/payout

Conversation

@AdyenAutomationBot
Copy link
Collaborator

This PR contains the automated changes for the payout service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot AdyenAutomationBot requested review from a team as code owners March 20, 2026 10:37
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces automated code generation updates for the payout service. The changes primarily consist of stylistic improvements, such as migrating string concatenations to f-strings and reformatting API client method calls for better code consistency and adherence to modern Python practices. These updates reflect recent commits from the adyen-openapi project.

Highlights

  • Code Style Update: Updated string concatenation for API endpoints to use f-strings for improved readability and modern Python syntax.
  • Code Formatting: Reformatted multi-line function calls to self.client.call_adyen_api into single-line statements across multiple service files.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@sonarqubecloud
Copy link

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request contains automated code generation changes for payout services. The modifications primarily involve formatting and how endpoint URLs are constructed. My review identifies an opportunity to improve the URL construction by using f-strings more idiomatically. The suggested changes aim to enhance code readability and maintainability across the updated files.

Store payout details
"""
endpoint = self.baseUrl + "/storeDetail"
endpoint = self.baseUrl + f"/storeDetail"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The use of an f-string for a static string /storeDetail is unnecessary, and concatenating it with self.baseUrl is not ideal. For better readability and to follow Python best practices, you can use a single f-string to construct the entire endpoint URL.

Suggested change
endpoint = self.baseUrl + f"/storeDetail"
endpoint = f'{self.baseUrl}/storeDetail'

Store details and submit a payout
"""
endpoint = self.baseUrl + "/storeDetailAndSubmitThirdParty"
endpoint = self.baseUrl + f"/storeDetailAndSubmitThirdParty"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The use of an f-string for a static string /storeDetailAndSubmitThirdParty is unnecessary, and concatenating it with self.baseUrl is not ideal. For better readability and to follow Python best practices, you can use a single f-string to construct the entire endpoint URL.

Suggested change
endpoint = self.baseUrl + f"/storeDetailAndSubmitThirdParty"
endpoint = f'{self.baseUrl}/storeDetailAndSubmitThirdParty'

Submit a payout
"""
endpoint = self.baseUrl + "/submitThirdParty"
endpoint = self.baseUrl + f"/submitThirdParty"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The use of an f-string for a static string /submitThirdParty is unnecessary, and concatenating it with self.baseUrl is not ideal. For better readability and to follow Python best practices, you can use a single f-string to construct the entire endpoint URL.

Suggested change
endpoint = self.baseUrl + f"/submitThirdParty"
endpoint = f'{self.baseUrl}/submitThirdParty'

Make an instant card payout
"""
endpoint = self.baseUrl + "/payout"
endpoint = self.baseUrl + f"/payout"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The use of an f-string for a static string /payout is unnecessary, and concatenating it with self.baseUrl is not ideal. For better readability and to follow Python best practices, you can use a single f-string to construct the entire endpoint URL.

Suggested change
endpoint = self.baseUrl + f"/payout"
endpoint = f'{self.baseUrl}/payout'

Confirm a payout
"""
endpoint = self.baseUrl + "/confirmThirdParty"
endpoint = self.baseUrl + f"/confirmThirdParty"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The use of an f-string for a static string /confirmThirdParty is unnecessary, and concatenating it with self.baseUrl is not ideal. For better readability and to follow Python best practices, you can use a single f-string to construct the entire endpoint URL.

Suggested change
endpoint = self.baseUrl + f"/confirmThirdParty"
endpoint = f'{self.baseUrl}/confirmThirdParty'

Cancel a payout
"""
endpoint = self.baseUrl + "/declineThirdParty"
endpoint = self.baseUrl + f"/declineThirdParty"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The use of an f-string for a static string /declineThirdParty is unnecessary, and concatenating it with self.baseUrl is not ideal. For better readability and to follow Python best practices, you can use a single f-string to construct the entire endpoint URL.

Suggested change
endpoint = self.baseUrl + f"/declineThirdParty"
endpoint = f'{self.baseUrl}/declineThirdParty'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant