[payout] Code generation: update services and models#448
[payout] Code generation: update services and models#448AdyenAutomationBot wants to merge 1 commit intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces automated code generation updates for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
There was a problem hiding this comment.
Code Review
This pull request contains automated code generation changes for payout services. The modifications primarily involve formatting and how endpoint URLs are constructed. My review identifies an opportunity to improve the URL construction by using f-strings more idiomatically. The suggested changes aim to enhance code readability and maintainability across the updated files.
| Store payout details | ||
| """ | ||
| endpoint = self.baseUrl + "/storeDetail" | ||
| endpoint = self.baseUrl + f"/storeDetail" |
There was a problem hiding this comment.
The use of an f-string for a static string /storeDetail is unnecessary, and concatenating it with self.baseUrl is not ideal. For better readability and to follow Python best practices, you can use a single f-string to construct the entire endpoint URL.
| endpoint = self.baseUrl + f"/storeDetail" | |
| endpoint = f'{self.baseUrl}/storeDetail' |
| Store details and submit a payout | ||
| """ | ||
| endpoint = self.baseUrl + "/storeDetailAndSubmitThirdParty" | ||
| endpoint = self.baseUrl + f"/storeDetailAndSubmitThirdParty" |
There was a problem hiding this comment.
The use of an f-string for a static string /storeDetailAndSubmitThirdParty is unnecessary, and concatenating it with self.baseUrl is not ideal. For better readability and to follow Python best practices, you can use a single f-string to construct the entire endpoint URL.
| endpoint = self.baseUrl + f"/storeDetailAndSubmitThirdParty" | |
| endpoint = f'{self.baseUrl}/storeDetailAndSubmitThirdParty' |
| Submit a payout | ||
| """ | ||
| endpoint = self.baseUrl + "/submitThirdParty" | ||
| endpoint = self.baseUrl + f"/submitThirdParty" |
There was a problem hiding this comment.
The use of an f-string for a static string /submitThirdParty is unnecessary, and concatenating it with self.baseUrl is not ideal. For better readability and to follow Python best practices, you can use a single f-string to construct the entire endpoint URL.
| endpoint = self.baseUrl + f"/submitThirdParty" | |
| endpoint = f'{self.baseUrl}/submitThirdParty' |
| Make an instant card payout | ||
| """ | ||
| endpoint = self.baseUrl + "/payout" | ||
| endpoint = self.baseUrl + f"/payout" |
There was a problem hiding this comment.
The use of an f-string for a static string /payout is unnecessary, and concatenating it with self.baseUrl is not ideal. For better readability and to follow Python best practices, you can use a single f-string to construct the entire endpoint URL.
| endpoint = self.baseUrl + f"/payout" | |
| endpoint = f'{self.baseUrl}/payout' |
| Confirm a payout | ||
| """ | ||
| endpoint = self.baseUrl + "/confirmThirdParty" | ||
| endpoint = self.baseUrl + f"/confirmThirdParty" |
There was a problem hiding this comment.
The use of an f-string for a static string /confirmThirdParty is unnecessary, and concatenating it with self.baseUrl is not ideal. For better readability and to follow Python best practices, you can use a single f-string to construct the entire endpoint URL.
| endpoint = self.baseUrl + f"/confirmThirdParty" | |
| endpoint = f'{self.baseUrl}/confirmThirdParty' |
| Cancel a payout | ||
| """ | ||
| endpoint = self.baseUrl + "/declineThirdParty" | ||
| endpoint = self.baseUrl + f"/declineThirdParty" |
There was a problem hiding this comment.
The use of an f-string for a static string /declineThirdParty is unnecessary, and concatenating it with self.baseUrl is not ideal. For better readability and to follow Python best practices, you can use a single f-string to construct the entire endpoint URL.
| endpoint = self.baseUrl + f"/declineThirdParty" | |
| endpoint = f'{self.baseUrl}/declineThirdParty' |



This PR contains the automated changes for the
payoutservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.