proxy: preserve zero TTL in respectTTLOverrides#491
Open
hengwu0 wants to merge 1 commit intoAdguardTeam:masterfrom
Open
proxy: preserve zero TTL in respectTTLOverrides#491hengwu0 wants to merge 1 commit intoAdguardTeam:masterfrom
hengwu0 wants to merge 1 commit intoAdguardTeam:masterfrom
Conversation
TTL=0 means the response must not be cached and should only be used for the current transaction. Before this change, respectTTLOverrides() promoted TTL=0 to cacheMinTTL, which could turn a non-cacheable response into a cacheable one. Skip the minimum TTL override when ttl is zero so zero-TTL responses preserve their original semantics. Signed-off-by: hengwu0 <17380582683@163.com>
Author
|
fixed #490 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TTL=0 means the response must not be cached and should only be used for the current transaction.
Before this change, respectTTLOverrides() promoted TTL=0 to cacheMinTTL, which could turn a non-cacheable response into a cacheable one.
Skip the minimum TTL override when ttl is zero so zero-TTL responses preserve their original semantics.