Conversation
|
Tbh, I am not fully sure about the service part. Wouldn't it be better to implement #39 using kardianos/service (just like we do in AdGuard Home), and reuse it? |
|
As Said in AdguardTeam/AdGuardHome#1348, kardianos/service does not match the initscripts standard of openwrt, and openwrt require a makefile to add preinstalled packages to the final image. |
|
@honwen sure, and here's what we do in AGH to handle this: Search for |
|
This is an OpenWRT package, it doesn't belong here. On the good side, while this one downloaded a binary release, the merged package compiles the go sources. @honwen / @1715173329 maybe you're interested to get that merged? |
|
@dhewg I just made a basic init script, please make a test/review if you are free ;) |
|
Nice! There're a few small things I'd change, but it's not up to me ;) |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #111 +/- ##
=======================================
Coverage 66.04% 66.04%
=======================================
Files 37 37
Lines 2194 2194
=======================================
Hits 1449 1449
Misses 543 543
Partials 202 202 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
docs: https://openwrt.org/docs/guide-developer/packages