Open
Conversation
adebroux
approved these changes
Jun 27, 2025
adebroux
left a comment
adebroux
left a comment
There was a problem hiding this comment.
LGTM! Don't forget to update the version number
|
This one has conflicts |
oleksandrkaDev
force-pushed
the
upgrade-rn
branch
from
37da935 to
eb619d4
Compare
* Update packages * Address PR review feedback for custom SVG icons - Restrict URL loading to HTTPS only (drop http://) - Fix isSVG check to parse URL pathname instead of naive includes - Add in-memory SVG fetch cache to avoid repeated network requests - Add propTypes and fix Prettier/ESLint formatting in TintedSvgIcon - Remove console.error usage - Move react-native-svg to peerDependencies - Revert peerDependency version ranges to unconstrained Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Fix URL parsing for Android native --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The old version of the component not work with the new version of React Native
Solution
Upgrade libs