Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the component to be compatible with the latest React Native by bumping core library versions, adding necessary peer dependencies, and switching some packages to updated forks.
- Bumps package version to 2.0.6
- Adds
peerDependenciesfor React, React-DOM, and React Native WebView - Upgrades React, React-DOM, react-art,
@adalo/cli, and swaps in GitHub-forked packages for key dependencies
Comments suppressed due to low confidence (1)
package.json:52
- The
react-artpackage may not have a published18.2.0version. Please verify that this exact version exists or adjust to a valid semver range (e.g.,^18.2.0) or the correct package version.
"react-art": "18.2.0",
| "react": "18.2.0", | ||
| "react-art": "18.2.0", | ||
| "react-dom": "18.2.0", | ||
| "react-native-web": "AdaloHQ/react-native-web" |
There was a problem hiding this comment.
[nitpick] Consider pinning the GitHub dependency to a specific tag or commit SHA to ensure consistent installs and avoid breaking changes from the default branch.
Suggested change
| "react-native-web": "AdaloHQ/react-native-web" | |
| "react-native-web": "AdaloHQ/react-native-web#<commit-sha>" |
| "react-native-swift": "^1.2.3", | ||
| "react-native-track-player": "4.1.1", | ||
| "react-native-vector-icons": "^6.6.0", | ||
| "react-native-track-player": "github:puckey/react-native-track-player#feature/update-react-native", |
There was a problem hiding this comment.
[nitpick] Lock this fork reference to a commit SHA or tagged release instead of a branch to prevent unintended updates when the branch is modified.
Suggested change
| "react-native-track-player": "github:puckey/react-native-track-player#feature/update-react-native", | |
| "react-native-track-player": "github:puckey/react-native-track-player#<commit-sha-or-tag>", |
danicunhac
reviewed
Jul 7, 2025
danicunhac
approved these changes
Jul 7, 2025
oleksandrkaDev
force-pushed
the
update-rn
branch
from
7abc0d7 to
50f8853
Compare
* Fix unworking audio plater stoping track * Bump version to 2.1.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The old version of the component not work with the new version of React Native
Solution
Upgrade fallen libs