Conversation
nucks
reviewed
Apr 1, 2022
TDH55
reviewed
Apr 1, 2022
Comment on lines
+205
to
+213
| if (topScreen && Math.round(progress * 10000) / 10000 >= 1) { | ||
| const { updatePlayed, updateProgress, endSong } = this.props | ||
|
|
||
| updatePlayed(0) | ||
| updateProgress(0) | ||
|
|
||
| endSong() | ||
| updatePlaying(false) | ||
| } |
Contributor
There was a problem hiding this comment.
I believe this same (or very similar) logic exists in ProgressBar, do you have any ideas why it needs to be here for Android? I think we probably need to either move it here entirely or check the platform and only execute this code on Android.
Contributor
There was a problem hiding this comment.
I have the same question as Taylor, if the code already exists in ProgressBar, why do we need it here?
Co-authored-by: Cameron Nuckols <camnuckols@gmail.com>
scott-massey
reviewed
Apr 4, 2022
Contributor
scott-massey
left a comment
scott-massey
left a comment
There was a problem hiding this comment.
Already separately added my comment!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds an
endSong()call at to the componentDidupdate