Skip to content

aapcs64: fix broken link#370

Merged
smithp35 merged 1 commit intoARM-software:mainfrom
yury-khrustalev:patch/issue-347
Mar 3, 2026
Merged

aapcs64: fix broken link#370
smithp35 merged 1 commit intoARM-software:mainfrom
yury-khrustalev:patch/issue-347

Conversation

@yury-khrustalev
Copy link
Contributor

Fixes #347

Copy link
Contributor

@smithp35 smithp35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I've worked out how to do this without changing the user visible text, see inline comment.

the call preserves ZA `every time <each normal return>`_ that the call
returns normally. A call trivially satisfies this requirement if the
the call preserves ZA every time that the call
`returns normally`_. A call trivially satisfies this requirement if the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an invisible anchor on line 1289 that this is supposed to target, which is close to returns normally

.. _`each normal return`:

I've been trying to get that to work, but have been failing [1]

However as that anchor is invisible, we can just rename it:

.. _`every time`:

Then in each of the references we can just use

`every time`_

I've checked that works with rstcheck and rst2pdf and doesn't need any wording or location changes.

[1]
I expect the rendering problems are caused by:

`every time <each normal return>`_

Which seems to interpret each normal return as a hyperlink.

According to Sphinx https://www.sphinx-doc.org/en/master/usage/referencing.html#role-ref

we should be using

:ref:`every time <each normal return>`

But I can't get our rst2pdf or rstcheck to understand :ref:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've updated patch as recommended.

Copy link
Contributor

@smithp35 smithp35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Will merge as this is NFC.

@smithp35 smithp35 merged commit fc9f506 into ARM-software:main Mar 3, 2026
1 check passed
@yury-khrustalev yury-khrustalev deleted the patch/issue-347 branch March 3, 2026 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken link in section 6.6 of aapcs64

2 participants