Conversation
smithp35
left a comment
There was a problem hiding this comment.
I think I've worked out how to do this without changing the user visible text, see inline comment.
aapcs64/aapcs64.rst
Outdated
| the call preserves ZA `every time <each normal return>`_ that the call | ||
| returns normally. A call trivially satisfies this requirement if the | ||
| the call preserves ZA every time that the call | ||
| `returns normally`_. A call trivially satisfies this requirement if the |
There was a problem hiding this comment.
There is an invisible anchor on line 1289 that this is supposed to target, which is close to returns normally
.. _`each normal return`:
I've been trying to get that to work, but have been failing [1]
However as that anchor is invisible, we can just rename it:
.. _`every time`:
Then in each of the references we can just use
`every time`_
I've checked that works with rstcheck and rst2pdf and doesn't need any wording or location changes.
[1]
I expect the rendering problems are caused by:
`every time <each normal return>`_
Which seems to interpret each normal return as a hyperlink.
According to Sphinx https://www.sphinx-doc.org/en/master/usage/referencing.html#role-ref
we should be using
:ref:`every time <each normal return>`
But I can't get our rst2pdf or rstcheck to understand :ref:
There was a problem hiding this comment.
Thanks, I've updated patch as recommended.
6a93437 to
82d01f5
Compare
smithp35
left a comment
There was a problem hiding this comment.
LGTM, thanks. Will merge as this is NFC.
Fixes #347