Adding function to overplot specific QC tests on 1D time-series data#996
Adding function to overplot specific QC tests on 1D time-series data#996cgodine wants to merge 4 commits intoARM-DOE:mainfrom
Conversation
|
@zssherman the original test images had the Data Quality Office watermark on them, which is why I assumed tests were failing. I recreated images and they passed local pytest run, so I replaced old ones. It looks like they're still failing so I will need to investigate further. |
act/plotting/timeseriesdisplay.py
Outdated
| ][bit - 1] | ||
|
|
||
| # Get the proper keys for plot color | ||
| if 'Bad' in bit_assessment: |
There was a problem hiding this comment.
I think you need to revisit this part of the code. the variable is plot_color but you're assigning an assessment to it. When I tried to overplot Suspect data, this failed.
There was a problem hiding this comment.
Renamed variable to plot_assessment to better reflect what is being assigned. Also fixed the logic for determining which assessment category the bit is in by using the assessment_overplot_category dict passed in the keyword args. Suspect data should now be plotted as such.
act/plotting/timeseriesdisplay.py
Outdated
| lines.extend(qc_ax) | ||
| labels.append(assessment) | ||
| add_legend = True | ||
| plot_color = assessment_overplot_category_color[bit_assessment] |
There was a problem hiding this comment.
This should return a color but then that's difference from the Incorrect/Suspect being assigned a couple lines up
There was a problem hiding this comment.
Fixed this with the rename of the variable and improvements to logic.
Currently, there is functionality to overplot QC variables by assessment type (#244). However, this plots only by the assessment type. I have added code that will plot specific QC tests by test/bit number. Passing an integer of the test number will overplot that test's flagged data onto the plot:

Passing a list of integers will plot those test numbers:
