Skip to content

Cherrypick libaom nasm fix#3104

Open
y-guyon wants to merge 1 commit intoAOMediaCodec:mainfrom
y-guyon:nasm_aom
Open

Cherrypick libaom nasm fix#3104
y-guyon wants to merge 1 commit intoAOMediaCodec:mainfrom
y-guyon:nasm_aom

Conversation

@y-guyon
Copy link
Contributor

@y-guyon y-guyon commented Mar 16, 2026

Fixes #3103

@y-guyon y-guyon marked this pull request as ready for review March 16, 2026 16:19
@vrabaud vrabaud requested a review from wantehchang March 16, 2026 16:24
Copy link
Collaborator

@wantehchang wantehchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

# build/_deps/libaom-src/CMakeLists.txt:73 (include)
# TODO: Remove the patch when using a libaom version past
# https://aomedia.googlesource.com/aom/+/6d2b7f71b98bfa28e372b1f2d85f137280bdb3de%5E%21/
PATCH_COMMAND git apply ${AVIF_SOURCE_DIR}/cmake/Modules/LocalAom.diff
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should add a changelog entry?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unsupported nasm: multipass optimization not supported

2 participants