Added DirectParentID & Primary "ParentID" in WCSimRootCherenkovHitTime, WCSimRootTrack, WCSimTrackInformation etc and made corresponding changes in WCSim.#23
Open
dhavvval wants to merge 3 commits intoANNIEsoft:anniefrom
Conversation
Uncommented /run/beamOn and set number of events to 1000
Turned off PMT by PMT QE
…e, WCSimRootTrack, WCSimTrackInformation etc and made corresponding changes in WCSim.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made improvements on WCSim as per A. Sutton's suggestions, I have uploaded the initial plan of action in docdb.
I have updated WCSim based on Andrew’s feedback. These changes are necessary for neutron clustering, as using
DirectParentTrackIDs allows us to identify the immediate parents of MCHits, rather than tracking them back to the primary parents as the current version of WCSim does.Additionally, I have updated sample-root-scripts/sample_readfile.C to read WCSim files standalone for verification purposes, without need of ToolAnalysis.
I am also currently integrating these WCSim changes into the ToolAnalysis workflow. This is almost complete; I am performing final-stage testing and ensuring compatibility with the recent changes in EventBuildingV2.
P.S.:- Please let me know if you would like me to give a short presentation on these updates during the next software/analysis meeting.