Skip to content

Add an option for setting maximum current limit#5

Open
ilario wants to merge 2 commits intoAFMD:masterfrom
ilario:master-max_current
Open

Add an option for setting maximum current limit#5
ilario wants to merge 2 commits intoAFMD:masterfrom
ilario:master-max_current

Conversation

@ilario
Copy link
Copy Markdown
Contributor

@ilario ilario commented Jul 6, 2017

The current limit is set to 0.0001 A which is often too low, added the possibility to set it via a command line option.

@greyltc
Copy link
Copy Markdown
Collaborator

greyltc commented Jul 11, 2017

I'm not 100% sure I want this (but I probably do). I'll leave it hard coded at 10mA for now.

@ilario
Copy link
Copy Markdown
Contributor Author

ilario commented Jul 11, 2017

Actually in the code 0.1 mA is the hard coded value.
I would also suggest to introduce an option for setting the range to auto, which usually for perovskite solar cells is a very bad idea, but in the case of MPPT should be ok in my opinion.

@ilario
Copy link
Copy Markdown
Contributor Author

ilario commented Jul 12, 2017

Ah sorry, I didn't notice 6dbc359 :) so now the limit is 10 mA :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants