Refactoring, packaging and imports optimization#19
Merged
Conversation
… calls in ARCANA tests.
…, add some tests and move aracan utils test to the correct location.
cgueck895
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several refactorings and improvements to enhance the project's maintainability, performance, and robustness.
Logging
__init__.py. Logging is now configured once upon import usinglogging.yaml.setup_loggingincore/_logs.pyto handle missing configuration files gracefully. It now defaults to a basic configuration (logging.basicConfig) instead of raising errors when a configuration file is missing or malformed, making the package more library-friendly.setup_loggingcalls across multiple modules (fault_detector.py,fault_detection_model.py,quick_fault_detector.py).Performance
calculate_criticalityinenergy_fault_detector/utils/analysis.pyto usenumpyvectorized operations and an efficient bounded cumulative sum loop. This provides a performance boost for large time-series datasets.Infrastructure and Project Structure
setup.py,requirements.txt, and.coveragercto a modernpyproject.tomlstructure.