Conversation
…name release pattern Co-authored-by: AD-Archer <89430358+AD-Archer@users.noreply.github.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can generate a title for your PR based on the changes.Add |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 59033ebb2b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| find target/dx -path "*/release/android/*" -type f \ | ||
| \( -name "*.apk" -o -name "*.aab" \) \ |
There was a problem hiding this comment.
Keep signing logic aligned with new artifact name filter
This change now accepts any *.apk/*.aab under the release path, but the signing stage still only signs files matching *release* in bundle-android.sh (the loops over $OUT_DIR/*release*.apk and $OUT_DIR/*release*.aab). In the exact scenario this patch targets—artifacts whose filenames do not include release—the build will now succeed and publish binaries, but they remain unsigned, which can break production distribution (e.g., Play upload/install trust expectations).
Useful? React with 👍 / 👎.
No description provided.