Skip to content

Merge pull request #58 from AD-Archer/copilot/fix-android-build-issue#59

Merged
AD-Archer merged 3 commits intoprodfrom
main
Mar 12, 2026
Merged

Merge pull request #58 from AD-Archer/copilot/fix-android-build-issue#59
AD-Archer merged 3 commits intoprodfrom
main

Conversation

@AD-Archer
Copy link
Owner

No description provided.

Copilot AI and others added 3 commits March 12, 2026 18:47
@coderabbitai
Copy link

coderabbitai bot commented Mar 12, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 49bdd017-4c45-440c-ade1-49835687b4ad

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch main
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can generate a title for your PR based on the changes.

Add @coderabbitai placeholder anywhere in the title of your PR and CodeRabbit will replace it with a title based on the changes in the PR. You can change the placeholder by changing the reviews.auto_title_placeholder setting.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 59033ebb2b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +12 to +13
find target/dx -path "*/release/android/*" -type f \
\( -name "*.apk" -o -name "*.aab" \) \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep signing logic aligned with new artifact name filter

This change now accepts any *.apk/*.aab under the release path, but the signing stage still only signs files matching *release* in bundle-android.sh (the loops over $OUT_DIR/*release*.apk and $OUT_DIR/*release*.aab). In the exact scenario this patch targets—artifacts whose filenames do not include release—the build will now succeed and publish binaries, but they remain unsigned, which can break production distribution (e.g., Play upload/install trust expectations).

Useful? React with 👍 / 👎.

@AD-Archer AD-Archer merged commit 5a5d3f6 into prod Mar 12, 2026
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants