Conversation
PHP (PHPUnit via wp-env): - composer.json with phpunit/phpunit ^9.6 - phpunit.xml.dist pointing at tests/php/ - tests/bootstrap.php loads WP test lib and plugin - tests/php/class-test-helpers.php — WP_GPSE_Helpers output assertions - tests/php/class-test-frontend.php — shortcode, form/block value population, redirect guard - tests/php/class-test-admin.php — settings registration, link injection - tests/php/class-test-uninstall.php — verifies all three options removed on uninstall JS (Jest via wp-scripts): - gpse/src/search-results/index.test.js — block registration, category, title, save() Infrastructure: - .wp-env.json — wp-env Docker config (PHP 8.2, plugin mounted) - Add @wordpress/env devDependency - Add test:php, env:start, env:stop, env:clean npm scripts - Scope test:unit to gpse/src to avoid scanning PHP test dirs
- @wordpress/env ^10.0.0 → ^11.2.0 (latest) - phpunit/phpunit ^9.6 → ^11.1 (current supported line for PHP 8.2 + WP 6.9) - phpunit.xml.dist: update schema to 11.5, remove attributes dropped in PHPUnit 10+ (convertErrorsToExceptions, convertNoticesToExceptions, convertWarningsToExceptions)
Three jobs run on every PR to main: - test-php: PHPUnit against PHP 8.2 and 8.3, WordPress latest, MySQL 8.0 - test-js: Jest (npm run test:unit) - lint: wp-scripts lint-js + lint-style Also adds bin/install-wp-tests.sh — standard WP plugin script that installs WordPress core and the phpunit test library into /tmp for the PHP job.
- actions/checkout v4 → v6.0.2 - actions/setup-node v4 → v6.3.0 - shivammathur/setup-php v2 → 2.37.0 - ramsey/composer-install v3 → 4.0.0
- Add subversion install step to PHP jobs (Ubuntu 24.04 no longer ships with svn) - Update package-lock.json to include @wordpress/env (was missing, broke npm ci)
PHP: Remove MYSQL_DATABASE from service env — install_db creates it, so the pre-created DB caused mysqladmin to error with 'database exists' Lint JS: Scope lint:js to gpse/src (exclude pre-existing gpse/assets/js/ violations). Add .eslintrc.js to mark @wordpress/* imports as externally resolved — they are webpack externals, not npm packages Jest: Rewrite index.test.js to test block.json metadata directly instead of importing index.js, which requires @wordpress/blocks at runtime
Makefile: - make lint — runs lint:js (gpse/src) + lint:css, mirrors CI lint job - make test-js — runs Jest via wp-scripts, mirrors CI test-js job - make test-php — starts wp-env and runs PHPUnit, mirrors CI test-php job - make test — runs test-js + test-php - Updated help and .PHONY .eslintrc.js: - Add jest env override for *.test.js files so describe/it/expect are recognised as globals (fixes CI lint failure)
gpse/assets/css/gpse.css: - Break long comment (line 20, 85 chars) to satisfy max-line-length - Reorder selectors: td.gsc-orderby-container (lower specificity) now precedes .gsc-resultsHeader td.gsc-orderby-container (higher) .stylelintignore: - Exclude dist/, gpse/build/, node_modules/ — all build artifacts
- Downgrade PHPUnit to ^9.6 (WP 6.9.4 test framework uses parseTestMethodAnnotations which was removed in PHPUnit 10) - Switch yoast/phpunit-polyfills to ^3.0 (compatible with PHPUnit 9-11) - Add docker-compose.test.yml and docker/Dockerfile.test for local parity with CI - Fix install-wp-tests.sh: add --skip-ssl to mysqladmin to bypass MariaDB SSL default, check includes/ dir instead of parent dir so cached Docker volume doesn't skip SVN checkout, tolerate pre-existing test database - Rename test files to match class names (PHPUnit 11 derives class name from filename; fix for any future upgrade too) - Remove directory prefix/suffix from phpunit.xml.dist to discover by class name - Add Makefile targets: lint, test-js, test-php, test
MySQL 8.0 client uses --ssl-mode=DISABLED; MariaDB uses --skip-ssl. Detect the client at runtime and select the correct option so the DB creation step works in both the Docker environment (MariaDB client) and GitHub Actions (MySQL 8.0 client).
caching_sha2_password (MySQL 8.0 default) requires a secure connection. --ssl-mode=DISABLED broke auth. The MySQL 8.0 client default (PREFERRED) uses SSL without verifying the self-signed cert, which is what we want. Only MariaDB client needs --skip-ssl to avoid self-signed cert errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New files
Running the tests locally
Test plan