Skip to content

Bi-directional communication with bot#42

Closed
eslindsey wants to merge 5 commits into5andr0:masterfrom
eslindsey:feedback-from-bot
Closed

Bi-directional communication with bot#42
eslindsey wants to merge 5 commits into5andr0:masterfrom
eslindsey:feedback-from-bot

Conversation

@eslindsey
Copy link
Copy Markdown
Contributor

@eslindsey eslindsey commented Aug 1, 2016

This branch enables bi-directional communication with PokeMobBot after Pull Request 225 which allows these bots to be turned into coordbots during normal operation (wild encounters and lure encounters). Settings are changed with a new element:

"EchoEncounters": [
    {
      "Format": "{0:0.00000000},{1:0.00000000} {2:0.00}% IV {4} {5} {6}",
      "Always": false,
      "MinimumIv": 90.0,
      "Ids": null,
      "Moves": null,
      "MovesToMatch": 0,
      "Channels": {
        "PokeMobBot": [
          "90_plus_iv",
          "locationsandroutes"
        ]
      }
    }
  ],

Format is a formatted string with the replaceable parameters 0: latitude, 1: longitude, 2: IV, 3: timestamp, 4: ID, 5: move 1, 6: move 2
Always means this rule will always match (should be used for testing only)
MinimumIv means this rule will match if IV is above a certain percentage
Ids means this rule will match only certain Pokemon
Moves means this rule will match certain Pokemon moves
MovesToMatch is the minimum number of listed moves (above) that must be present
Channels is an array with keys that match case-insensitive substrings of the servers you have access to, the the value is an array of the exact names of the channels in that server you want to broadcast to

One rule can be created to broadcast to multiple channels on multiple servers. If MinimumIv and Ids are both specified, then both must match ("and" behavior).

@Ilses
Copy link
Copy Markdown
Collaborator

Ilses commented Aug 2, 2016

We'll need to talk with Discord staff about running this data through Discord first, since it seems we've been causing traffic issues. If we get a dedicated server up and running, we'd definitely like to look into a crowdsourced sniper feed!

On hold for now

@Rabelaiss
Copy link
Copy Markdown

Holy s**t! This is awesome! If lot of people use this, pogo api wont be necessary anymore to snipe

@LNSDISCORDER
Copy link
Copy Markdown

LNSDISCORDER commented Aug 3, 2016

What i want to know is, does it potentially create a snipe loop (potentially only twice i guess) on the same pokes fed back to itself.

Example:
LF picks up a snorlax from a channel, the bot snipes that snorlax then feeds that snorlax to LF, which feeds that to a channel that the feeder then reads and sends the bot back to check that snipe spot for said snorlax?

Prolly going to get my ass chewed out for not looking through the code again to check that its getting the data from wild hunting and not sniping. On the surface though, it looks to me like its only reading the catch line. (on PokeMobBot code i mean)

What we do need to do though is move away from discord servers and push this to IRC.

@eslindsey
Copy link
Copy Markdown
Contributor Author

eslindsey commented Aug 3, 2016

@LNSDISCORDER PokeMobBot #225, the counterpart to this PR, only echoes Wild and Lure encounters (as I mentioned in the OP), so no snipe loop.

@ExcuseMi
Copy link
Copy Markdown
Collaborator

Was this accepted into the pokemobbot/necro?

@eslindsey
Copy link
Copy Markdown
Contributor Author

No, the thinking was that it might put an undue load on the Discord servers.

On Aug 14, 2016, at 6:24 PM, ExcuseMi notifications@github.com wrote:

Was this accepted into the pokemobbot/necro?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@ExcuseMi
Copy link
Copy Markdown
Collaborator

Wait, it didn't get accepted by pogofeeder or by the bot team?
I coded kinda the same using the websocket necro and pokemobbot support.
Sadly, I only get the pokemonid & iv & location.
It get sent back to the server (if the pogofeeder that received it is connect our a server instance), and the server decides if it's a known location or a new pokemon.
I'm also gonna let the server decided which pokemon & iv's it wants to receive.

@eslindsey
Copy link
Copy Markdown
Contributor Author

Both PogoLocationFeeder and the bot teams had the same concerns about flooding Discord.

My code only relays lure and random encounters, so every encounter should be unique unless you are in a nest (which would be valuable information to collect).

I added the Move1 and Move2 support myself. Previously I also only got ID, IV, and location.

On Aug 15, 2016, at 5:27 AM, ExcuseMi notifications@github.com wrote:

Wait, it didn't get accepted by pogofeeder or by the bot team?
I coded kinda the same using the websocket necro and pokemobbot support.
Sadly, I only get the pokemonid & iv & location.
It get sent back to the server (if the pogofeeder that received it is connect our a server instance), and the server decides if it's a known location or a new pokemon.
I'm also gonna let the server decided which pokemon & iv's it wants to receive.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@ExcuseMi ExcuseMi closed this Aug 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants