Open
Conversation
This commit makes the total file size to be system agnostic. Changing the function to calculate only when the etity is a FILE, this will prevent misscalculations to happen by adding DIRs to the sum, once a DIR size varies based on the OS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Upgraded
Riverpodtov3v3fvmrcto lock flutter version for developmentWhy?
This was one of the obstacles to upgrade all app dependencies.
How?
Revised the APIs being used from the
v2code, and upgraded tov3APIsTesting?
Test suite upgraded and passing locally
Screenshots (optional)
Anything Else?
EDIT: There was an edge case detected with the
_calculateMemoryUsage()function, where the final value would NOT be system agnostic, since it was including directories in the calculation. the commit 9a4162e , changed that.