Merged
Conversation
Contributor
|
I did a quick check, looks mostly good, worksheets and the settings respect the screen height. Only the menu doesn't unfortunately, see the screenshot: Can you fix that? And if that looks fine on your iphone and on a pixel simulator just merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Update widgets to respect screen safe are and set size for the language dropdown menu.
Why?
The app was not respecting the boundaries of the Android screen, and the language menu had the same issue.
How?
Wrapped key widgets with
SafeAreawidget and set the maximum size for height and width for the language menu.Testing?
Tested on Pixel 7 emulator.
Screenshots (optional)
Anything Else?