Skip to content

fix: Fix "to many steps: constrained dilation" exception for some cases#1220

Draft
Czaki wants to merge 10 commits intodevelopfrom
fix_multiple_otsu
Draft

fix: Fix "to many steps: constrained dilation" exception for some cases#1220
Czaki wants to merge 10 commits intodevelopfrom
fix_multiple_otsu

Conversation

@Czaki
Copy link
Collaborator

@Czaki Czaki commented Oct 24, 2024

Summary by Sourcery

Fix the 'to many steps: constrained dilation' exception by increasing the step_limits in MSOWatershedParams and update the CI pipeline to install a specific branch of PartSegCore-compiled-backend.

Bug Fixes:

  • Increase the upper limit of step_limits in MSOWatershedParams to prevent 'to many steps: constrained dilation' exceptions.

CI:

  • Update the Azure Pipelines configuration to install PartSegCore-compiled-backend from the 'mso_fix' branch.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 24, 2024

Reviewer's Guide by Sourcery

This PR addresses the "too many steps: constrained dilation" exception by increasing the maximum step limit in the watershed segmentation algorithm and updating the build pipeline to use a fixed version of the PartSegCore-compiled-backend.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Increased the maximum step limit in the watershed segmentation parameters
  • Changed the upper bound of step_limits from 1000 to 10000 in MSOWatershedParams class
  • Maintained the same lower bound (1) and default value (100)
package/PartSegCore/segmentation/watershed.py
Updated build pipeline to use fixed backend version
  • Added step to install PartSegCore-compiled-backend from 'mso_fix' branch
.azure-pipelines/pyinstaller.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 24, 2024

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0c0ca09e-bc96-4f25-96f5-c107b5dd7583

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix_multiple_otsu
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use OpenGrep to find security vulnerabilities and bugs across 17+ programming languages.

OpenGrep is compatible with Semgrep configurations. Add an opengrep.yml or semgrep.yml configuration file to your project to enable OpenGrep analysis.

@codecov
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.13%. Comparing base (979f440) to head (3edd15c).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1220      +/-   ##
===========================================
+ Coverage    93.12%   93.13%   +0.01%     
===========================================
  Files          211      211              
  Lines        33272    33272              
===========================================
+ Hits         30983    30988       +5     
+ Misses        2289     2284       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant