Rewrite and clarify some parts#4
Open
minhducsun2002 wants to merge 1 commit into42tm:masterfrom
minhducsun2002:rtwpl-fix
Open
Rewrite and clarify some parts#4minhducsun2002 wants to merge 1 commit into42tm:masterfrom minhducsun2002:rtwpl-fix
minhducsun2002 wants to merge 1 commit into42tm:masterfrom
minhducsun2002:rtwpl-fix
Conversation
cszach
requested changes
Aug 18, 2018
Member
cszach
left a comment
There was a problem hiding this comment.
I agree with most of your changes. Here are some that I don't:
- "call" and "claim" are very different, and I use the former because it is more generic, so you should just keep it.
- I think "when", in this context, is more appropriate than "upon".
- Change "if and only if his/her name" to "only if their name". I guess you took that "if and only if" from your Math teacher?
Member
Author
P/s : 1 and 2 are personal opinion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rephrase some parts of the license.
Also make some words stricter.