Handle ambiguous and nested encrypted QR codes, and hide legacy AES v1 modes#345
Open
earthdiver wants to merge 3 commits into3rdIteration:devfrom
Open
Handle ambiguous and nested encrypted QR codes, and hide legacy AES v1 modes#345earthdiver wants to merge 3 commits into3rdIteration:devfrom
earthdiver wants to merge 3 commits into3rdIteration:devfrom
Conversation
Author
|
Notes
At present, all of these new features are meaningful only when used in combination with Krux’s Datum tool. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added support for nested encrypted QR codes
(currently limited to static QR codes)
Added support for ambiguous QR codes. You can now choose in Settings how to handle QR codes that could be interpreted as either CompactSeedQR or EncryptedQR (or xprv).
Handle decrypted text from encrypted QR codes (as an alternative to PR Handle text payloads in encrypted QR decoding #175)
Hid legacy AES v1 modes from the encryption mode selector
This pull request is categorized as a:
Checklist
pytestand made sure all unit tests pass before sumbitting the PRIf you modified or added functionality/workflow, did you add new unit tests?
I have tested this PR on the following platforms/os: