Skip to content

Add lint check to CI#45

Merged
gviga merged 4 commits intomainfrom
ci
Jan 21, 2026
Merged

Add lint check to CI#45
gviga merged 4 commits intomainfrom
ci

Conversation

@luisfpereira
Copy link
Copy Markdown
Collaborator

@luisfpereira luisfpereira commented May 16, 2025

This PR updates CI to check linting.

(Still to early to activate this!)

@luisfpereira luisfpereira changed the title Update CI Add lint check to CI May 16, 2025
@luisfpereira luisfpereira marked this pull request as draft May 16, 2025 18:27
@luisfpereira luisfpereira reopened this May 16, 2025
@gviga gviga marked this pull request as ready for review December 30, 2025 12:07
@gviga
Copy link
Copy Markdown
Collaborator

gviga commented Dec 30, 2025

Hi @luisfpereira,

I've restored this PR and addressed the linting issues:

  • ✅ Added missing docstrings to public modules and functions
  • ✅ Fixed variable naming conventions (replaced single-letter uppercase variables)
  • ✅ Corrected typos in docstrings
  • ✅ Ensured all docstrings follow numpy-style conventions

The code now passes Ruff linting checks locally. I believe we're ready to activate these lint checks in the CI workflow.

@gviga gviga requested a review from GiLonga December 30, 2025 12:10
@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@gviga gviga merged commit 4de96a6 into main Jan 21, 2026
2 of 3 checks passed
@gviga gviga deleted the ci branch January 21, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants