Open
Conversation
Modified to allow input from text files.
…an error where if a single regex was input, it asked for the input twice. This is now fixed. *Prints prefix, pump, and suffix strings in JSON format. *Updated README output examples
ReScue can now accept input from a text file. This makes the program command-line friendly for use with other detectors and allows for multiple regexes to be detected with ease. Other changes: -Prints JSON formatted prefix, pump, and suffix -Updated usage message to indicate that -regex-file is an option.
ReScue can now accept input from a text file. This makes the program command-line friendly for use with other detectors and allows for multiple regexes to be detected with ease. Other changes: -Prints JSON formatted prefix, pump, and suffix -Updated usage message to indicate that -regex-file is an option.
|
Overall this looks fine. Your IDE has changed many lines for linting purposes, which makes this PR look a lot bigger than it really is. @emily-desverreaux I'm going to open a separate PR derived from your fork, and remove the unrelated line changes. |
|
This can be closed. Superseded by #6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for ReScue to accept input from a file containing multiple regexes, rather than a single line. I also made changes so that it prints the prefix, pump, and suffix in a JSON formatted string. I imported the Google GSON (v.2.6.2) library into the project for this.