Draft
Conversation
Add ResurrectionConcierge feature that mirrors the resurrection home widget server API check: the concierge will not show for members who are current direct depositors. Key components: - ResurrectionConciergeEligibilityChecker: checks direct deposit status first (returning ineligible for current direct depositors), then verifies the member is in the resurrection cohort - DirectDepositStatusProviding protocol: abstracts the DD status fetch - ResurrectionConciergeGenerator: popup generator with gating store - ResurrectionConciergeRegistration: app startup entrypoint - Full test coverage for eligibility checker and generator Co-authored-by: Andrew Kim <andrewkim2021@u.northwestern.edu>
|
Cursor Agent can help with this pull request. Just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a direct depositor check to the Resurrection Concierge to prevent it from showing to current direct depositors, consistent with the Resurrection Home Widget.
Slack Thread