This repository was archived by the owner on Apr 9, 2021. It is now read-only.
Open
Conversation
18F/site-scanning#788 - Adds Redux for global state management - Available Fields and Selected Fields components pull data from redux state - Available Fields components add fields to redux state - Selected Field buttons remove fields from redux state - Uses React Testing Library with a custom Redux wrapper to unit test new components - Adds Unit testing for each redux reducer
Add basic UI interactivity for field selection
I went with URLSearchParams over a custom package like query-string because it's a built-in, and with a polyfill it can support IE11. More info on URLSearchParams https://developer.mozilla.org/en-US/docs/Web/API/URLSearchParams Using this polyfill for IE: https://www.npmjs.com/package/url-search-params-polyfill
This allows users to go to a url with pre-set fields This uses the built-in URLSearchParams interface for parsing: https://developer.mozilla.org/en-US/docs/Web/API/URLSearchParams
set fields based on url params
When field is selected and it's filterable. the appropriate filter will appear underneath the checkbox Pending: passing Unit tests for UI components
Since filter fields are hidden until field is selected, user should know which fields can be filtered up-front. places icon of filter next to filterable field checkbox labels
795 implement ui for initial filters
- Loading State has progress bar - Success State has message, download button, and share button - Error State has message Note: non-funtional (UI-only)
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
- Reduce number of available fields shown - Add basic instructions - Switch main action from Build Report to Copy Url
…ionality Since the api will return all fields regardless of selection, there's no more need to select which fields you want to be present - also add initial buttons for sharing query
- keep url params in sync with user filters, so url is always sharable - fix bugs with available and selected fields not syncing - minor style updates / remove all the big buttons
also removes share this button
Now that the UI is somewhat finalized, some tests would be nice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.