feat: improve request handling by encapsulating body management and …

[AbdulRehman-z]

…by smart buffer management plus updating header retrieval

Summary by CodeRabbit

• New Features
  • Added a method to retrieve integer header values with a default fallback.
• Bug Fixes
  • Request parsing now returns an error when Content-Length does not match the received body.
• Refactor
  • Reworked request body handling to stream and buffer content efficiently, finalizing only after full read.
  • Removed verbose logging to reduce noise.
• Tests
  • Updated tests to reflect new body handling and to validate Content-Length mismatch errors.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Removes slog logging. Adds NewHeaders constructor and GetInt to headers. Refactors request parsing to stream the body using a byte buffer, replaces exported Body with internal fields, and uses Headers.GetInt for content-length. Updates tests to new body handling and adds an error case for length mismatch.

Changes

Cohort / File(s)	Summary of edits
Logging removal internal/headers/headers.go, internal/request/request.go	Deleted log/slog imports and all slog.Info calls.
Headers API additions internal/headers/headers.go	Added NewHeaders() constructor. Added GetInt(name, defaultValue) using strconv.Atoi. Adjusted imports.
Request body parsing refactor internal/request/request.go	Removed exported Body field. Introduced internal fields: body (string), bodyBuffer ([]byte), bodyPos (int). Switched to buffered body accumulation based on content-length via Headers.GetInt. Assigned final body on completion. Removed getInt helper.
Tests updated internal/request/request_test.go	Updated references from r.Body to r.body. Added/modified test to expect error on content-length/body mismatch.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant C as Client
  participant R as RequestFromReader
  participant P as Parser
  participant H as Headers

  C->>R: Provide reader stream
  R->>P: Initialize parser
  loop Read lines
    P->>H: Parse header lines
  end
  H-->>P: content-length via GetInt()
  alt content-length == 0 or missing
    P->>R: StateDone (no body)
  else content-length > 0
    P->>P: Allocate bodyBuffer[length], bodyPos=0
    loop Until bodyPos == length
      C-->>P: Chunk bytes
      P->>P: Copy into bodyBuffer, advance bodyPos
    end
    P->>P: body = string(bodyBuffer)
    P->>R: StateDone
  end

  opt Error path
    Note right of P: If stream ends before bodyPos == length
    P-->>R: Return error (length mismatch)
  end

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Poem

I nibble bytes with careful cheer,
A buffer burrow built right here.
Headers whisper counts to me,
I tally crumbs: one, two, three.
When lengths align, I thump—complete!
If short, I pause my hopping feet.
New trails, same moonlit, tidy beat. 🥕

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 6e83cfc and ffcb2e1.

📒 Files selected for processing (3)

• internal/headers/headers.go (3 hunks)
• internal/request/request.go (2 hunks)
• internal/request/request_test.go (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feature/optimization

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.