Move EboAlphaWritting over to MappedBufferIntWritter#986
Open
RuffledPlume wants to merge 10 commits into117HD:masterfrom
Open
Move EboAlphaWritting over to MappedBufferIntWritter#986RuffledPlume wants to merge 10 commits into117HD:masterfrom
RuffledPlume wants to merge 10 commits into117HD:masterfrom
Conversation
Resolves issues where there is no room left in the mapped buffer, since GLMappedBufferIntWritter will allocate stagingBuffers to hold the data temporarily
alphaModels are pushed in the order they should be uploaded in, so the offset is now redundant
This was always wrong anyway, since multiLoc could change the amount of alpha within a given zone
RuffledPlume
force-pushed
the
EboAlphaintWritter
branch
from
af88278 to
b855c6b
Compare
* EBOAlphaWritter needs to Sync with GPU since its not double buffered * Clean up state after doing Scene & Directional Pass * Ensure GLBuffer.Bind() is being used instead of glBindBuffer()
RuffledPlume
force-pushed
the
EboAlphaintWritter
branch
from
b855c6b to
09c3fb8
Compare
Contributor
Author
|
Since the bound EBO is part of VAO state, we probably shouldn't make it seem like it's global state by unbinding it right after explicitly unbinding the current VAO, even though it in practice makes no difference of course.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.