Skip to content

Fix: Propagate block index in recursive processing #1363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ggutenberg wants to merge 1 commit into
base: develop
Choose a base branch
from
+4 −1
Open

Fix: Propagate block index in recursive processing #1363

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion includes/classes/RegisteredDataHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public function search_replace_block_inner_content( $block, $replacement_strings
* @param array $extra_data Array of extra data provided by source for the registered data.
* @param array $post_data Array of post data.
* @param int $index Index of the extra data.
* @return array Array with 'blocks' (processed blocks) and 'modified' (bool).
* @return array Array with 'blocks' (processed blocks), 'modified' (bool), and 'index' (int).
*/
public function process_blocks_data_recursive( $blocks, $registered_data, $extra_data, $post_data, $index = 0 ) {
$callback_fn = $registered_data['post_distribute_cb'] ?? null;
Expand All @@ -79,6 +79,7 @@ public function process_blocks_data_recursive( $blocks, $registered_data, $extra
return array(
'blocks' => $blocks,
'modified' => $modified,
'index' => $index,
);
}

Expand Down Expand Up @@ -155,12 +156,14 @@ public function process_blocks_data_recursive( $blocks, $registered_data, $extra
$block['innerBlocks'] = $inner_result['blocks'];
$modified = true;
}
$index = $inner_result['index'];
}
}

return array(
'blocks' => $blocks,
'modified' => $modified,
'index' => $index,
);
}

Expand Down
Loading