-
Notifications
You must be signed in to change notification settings - Fork 0
CR #1
Copy link
Copy link
Open
Description
Critical
- custom hooks should be generic,
useGetTasks & useGetGroupsshould be one hook (suggest name as useFetch), which get url & options. - remove all unused imports(there is alot...)
- on AddTaskForm.js use useForm or formik. even useReducer would be better than so many useStates.
- export all possible metods which calling for the server to Actions folder/utils files, and send the relevant paramt to.
- map: seperate map component to: basic map, map raster layers, map vector layers, map events
- map: why map, overlay, source, are defined by useRef? זה פלסטר?!
- move useStyles functions outside from the react components, utils files or above it
- Task.js line 185, task != undefiend...
- Task.js line 227-234, it is not readable, please export as much logic as u can from the jsx section.
Standarts
- do no use ;
- useSelector instead of mapStateToProps
- useDispatch instead of mapDispatchToProps
- use prettier to arrange spaces (the code is too messy)
- there are lots of functions write this way:
const handleChange = (e) => { const value = e.target.value; setChange(value) }one line better solution:const handleChange = ({ target: { value } }) => setChange(value)
I was impressed by
- greate use at mui grid element
- u could not use vis timeline any better
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels