Skip to content

CR #1

@workgit1

Description

@workgit1

Critical

  1. custom hooks should be generic, useGetTasks & useGetGroups should be one hook (suggest name as useFetch), which get url & options.
  2. remove all unused imports(there is alot...)
  3. on AddTaskForm.js use useForm or formik. even useReducer would be better than so many useStates.
  4. export all possible metods which calling for the server to Actions folder/utils files, and send the relevant paramt to.
  5. map: seperate map component to: basic map, map raster layers, map vector layers, map events
  6. map: why map, overlay, source, are defined by useRef? זה פלסטר?!
  7. move useStyles functions outside from the react components, utils files or above it
  8. Task.js line 185, task != undefiend...
  9. Task.js line 227-234, it is not readable, please export as much logic as u can from the jsx section.

Standarts

  1. do no use ;
  2. useSelector instead of mapStateToProps
  3. useDispatch instead of mapDispatchToProps
  4. use prettier to arrange spaces (the code is too messy)
  5. there are lots of functions write this way: const handleChange = (e) => { const value = e.target.value; setChange(value) } one line better solution: const handleChange = ({ target: { value } }) => setChange(value)

I was impressed by

  1. greate use at mui grid element
  2. u could not use vis timeline any better

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions