-
Notifications
You must be signed in to change notification settings - Fork 9
Armor name weirdness #19
Copy link
Copy link
Open
Description
at
mhrice/src/extract/gen_pedia.rs
Line 1513 in cc94a49
| .get(armor_series.armor_series.0 as usize); // ?! |
mhrice/src/extract/gen_pedia.rs
Lines 1567 to 1574 in cc94a49
| let name = msg | |
| .entries | |
| .get(id) | |
| .with_context(|| format!("Cannot find name for armor {:?}", armor.pl_armor_id))?; // ?! | |
| let explain = explain_msg | |
| .entries | |
| .get(id) | |
| .with_context(|| format!("Cannot find name for armor {:?}", armor.pl_armor_id))?; // ?! |
where we look up the armor name from msg, unlike other names, we uses armor ID to match against msg entry index, instead of the msg entry name. This appears to be the correct matching, but why is it? Is this the actually correct method, or there is a hidden armor ID -> msg entry name mapping somewhere? Could we also be wrong about using msg entry name anywhere else?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels