Let's get our Javascript in order

[JustinSainton]

We have many, many areas in WPeC that need to be brought up to modernity in regards to javascript.

Gary has done a brilliant job on all of the new stuff, let's achieve plugin-wide parity across the board.

Here's the big tasks for this. Since we're new to this GitHub thing, I don't really care if these are broken out into smaller tickets or not - the reality is that it's not actually going to be a heavily resource-intensive effort.

• Proper AJAX throughout the javascript files. Gary has built an awesome WPSC AJAX API as of 3.8.9 - let's ensure this is used everywhere. (See issue Review and utilize (throughout core) our WPSC_Ajax API #368)
• Make decisions about what makes it into core JS files. Fancy Notifications? (see GC 296 ) ShareThis? Arguably, JS for these should not be in core files, rather, in plugin/theme related files. (See Issue Trim JS from core files, into plugins, as needed. #370)
• Avoid eval() - this requires no explanation. We're doing_this_wrong(). See GC 486.
• Properly reference our AJAX handler. There is no shortage of Nginx issues reported due to us using '/index.php' as an AJAX handler. See GC 713
• Be no more specific than we need to be with selectors. Naturally, some thought will need to be given here with regards to backwards compatibility as well as the new theme engine. But we needlessly cause issues like GC 365. (See Be only as specific as necessary with selectors. #371)
• Now is the time to move from .live() (or livequery(), or bind() or delegate() even) to .on(). See GC 556. To note, the patches there only affect .livequery() usage.
• We have SO MANY javascript files that we don't need. Not even for back compat. Let's get rid of them. (See Remove deprecated and unused javascript (and by extension, CSS) from core #372)

This would all be a brilliant start.

[JustinSainton]

Side note - we should really build a tutorial for the AJAX API. It's awesome, plugin authors should know it exists and how to use it.

[1bigidea]

Count me in for any part of this effort. Off to study the new Ajax API. Willing to tackle any part of this issue.

[JustinSainton]

Great to hear, Tom! We'll gladly take your help. Moving this to milestone 3.8.10 and will break it apart there.

[garyc40]

The AJAX API we introduced in 3.8.9 is for admin area only. It has its own problems (being too rigid with nonce checking). So that's one point to improve. Then we can take that whole thing and replicate it for the front-end as well.

We'll break this issue down into individual issues and start assigning once we get a clearer view what this involves. You're always welcome to join Tom!

[JustinSainton]

RE: point 7 on the list - Thickbox is a great example. See GC 1181

See also tinyMCE - GC 394

[benhuson]

As ShareThis has their own plugin...
http://wordpress.org/extend/plugins/share-this/
...maybe we should just make sure that WPEC is compatible with that?

I guess at least splitting these out into separate js files would help to start with.

[JustinSainton]

Yep, I think that's a great idea Ben. We could probably take some cues from core in how they've deprecated the Link Manager - we could run the same checks on update - if people have the option enabled, nag them to upgrade, otherwise, don't load the ShareThis stuff.

[leewillis77]

Re: the nginx issues - I run it locally - so happy to test ...

[benhuson]

Split out share this JS issue #187

[mimecine]

I just made a pull request ( #336 ) that should fix the ajax-nginx problems and still be compatible with apache

[instinct]

Thanks Marco. Appreciate the efforts :))

Ciao
Dan

On 17/04/2013, at 9:24 AM, Marco notifications@github.com wrote:

I just made a pull request ( #336 ) that should fix the ajax-nginx problems and still be compatible with apache

—
Reply to this email directly or view it on GitHub.