UI: Refactor Create Wizard Cards in Platform UI and Add Step 4 in CreateWiki.vue#1105
UI: Refactor Create Wizard Cards in Platform UI and Add Step 4 in CreateWiki.vue#1105rosalieper wants to merge 2 commits intomainfrom
Conversation
|
Deployment previews on netlify for branch
|
| @previous-step="goToStep(2)" | ||
| @submit="createWiki" | ||
| /> | ||
| <step-four-card |
There was a problem hiding this comment.
We don't want to include this Step Four in this PR. Implementing a new card isn't due until a later ticket: T419210 and it should be called KnowledgeEquityCreateWikiWizardStep
| import StepThreeCard from './CreateWikiWizardStepThree.vue' | ||
| import SiteDetailsCreateWikiWizardStep from './SiteDetailsCreateWikiWizardStep.vue' | ||
| import AudienceAndPurposeWizardStep from './AudienceAndPurposeWizardStep.vue' | ||
| import TemporalityProfileEditWizardStep from './TemporalityProfileEditWizardStep.vue' |
There was a problem hiding this comment.
We only need ...CreateWikiWikiWizardStep components in this CreateWiki card
| import SiteDetailsCreateWikiWizardStep from './SiteDetailsCreateWikiWizardStep.vue' | ||
| import AudienceAndPurposeWizardStep from './AudienceAndPurposeWizardStep.vue' | ||
| import TemporalityProfileEditWizardStep from './TemporalityProfileEditWizardStep.vue' | ||
| import TemporalityCreateWikiWizardStep from '@/components/Cards/TemporalityCreateWikiWizardStep.vue' |
There was a problem hiding this comment.
I think this @ symbol for importing probably works fine although I haven't tested it. I think we could stick with consistently using the same import type for all cases either ./ or @
| temporality: '', | ||
| otherTemporality: '' | ||
| }, | ||
| stepFour: { |
There was a problem hiding this comment.
As above we don't need a step four yet :)
| @click="submitWholeForm" | ||
| > | ||
| {{ submitButtonText }} | ||
| Create Wiki |
There was a problem hiding this comment.
This now needs to have a different value hardcoded because this component is now designed to be used in the ProfileEdit context. It should have "Set intended use" from https://github.com/wbstack/ui/pull/1105/changes#diff-65f4e79e86b49a3110f6196179d7d13de0b9d84e8cc5b8f42a42de0dbcb98273L24
| :error="dialog.error" | ||
| :dismissable="true" | ||
| :showTerms="false" | ||
| submitButtonText="Set intended use" |
There was a problem hiding this comment.
This no longer needs to be passed in since we hardcoded it above
|
|
||
| <script> | ||
| export default { | ||
| name: 'StepThreeCard', |
There was a problem hiding this comment.
Let us also change the name to match the filename here
|
|
||
| <script> | ||
| export default { | ||
| name: 'StepFourCard', |
There was a problem hiding this comment.
Let us also change the name to match the filename here
There was a problem hiding this comment.
Let us also change the exported name to match the filename here
There was a problem hiding this comment.
Let us also change the exported name to match the filename here
2 participants
Bug: T419207