CI/CD license validation stops working after upgrading to Vaadin 25.0

[F-Kamp]

Description of the bug

Hello,

my multi module Gradle Quarkus project is being built on Jenkins. After upgrading Vaadin from 24.8 to 25.0 the build stopped working.
I tried multiple things:

1. Generating an offline key using the new format (mid2) for the VM on which Jenkins runs the builds
2. Generating a server license key

I've tried supplying the license via environment variable and via Gradle property (-P ...). Nothing works with Vaadin 25.0. I always see the message that commercial features (Chart) are in use but no license is provided:

09:56:40  Execution failed for task ':dev-ui:vaadinBuildFrontend'.
09:56:40  > Commercial features require a subscription.
09:56:40    Your application contains the following commercial components and no license was found:
09:56:40    * vaadin-chart
09:56:40    
09:56:40    If you have an active subscription, please download the license key from https://vaadin.com/myaccount/licenses.
09:56:40    Otherwise go to https://vaadin.com/pricing to obtain a license.
09:56:40    
09:56:40    You can also build a watermarked version of the application configuring
09:56:40    the 'commercialWithBanner' property of the Maven or Gradle plugin
09:56:40    or run the build with the '-Dvaadin.commercialWithBanner' system parameter

Expected behavior

The existing server license should still work after updating Vaadin

Minimal reproducible example

Not really sure how I can create a reproducible example for this.
A minimal example demonstrating my build setup (Gradle, Quarkus, etc) can be found here

Versions

• Vaadin / Flow version: 25.0.0
• Java version: 21
• OS version: Fedora 40
• Browser version (if applicable):
• Application Server (if applicable):
• IDE (if applicable):

[mcollovati]

I would first recommend updating to the latest Vaadin 25.0 version, since a bug in License Checker preventing offline keys from being read from system properties and env variables was fixed.

About using property, I'm not a Gradle user/expert, but License Checker expects a system property (-Dvaadin.offlineKey) not a Gradle property. IIRC Gradle does not propagate system properties from the CLI to the tasks, nor it converts Gradle properties to system properties.

[F-Kamp]

My bad, I should have thought of checking the latest 25.0.x version.

The build still fails with 25.0.7, but now due to a Quarkus/Vaadin version conflict:

Gradle Test Executor 8 STANDARD_ERROR
    java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
        [error]: Build step io.quarkus.kubernetes.client.deployment.DevServicesKubernetesProcessor#setupKubernetesDevService threw an exception: java.lang.RuntimeException: java.lang.NoClassDefFoundError: com/fasterxml/jackson/annotation/JsonSerializeAs
        at io.quarkus.kubernetes.client.deployment.DevServicesKubernetesProcessor.setupKubernetesDevService(DevServicesKubernetesProcessor.java:140)
        at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:733)
        at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:898)
        at io.quarkus.builder.BuildContext.run(BuildContext.java:242)
        at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
        at org.jboss.threads.EnhancedQueueExecutor$Task.doRunWith(EnhancedQueueExecutor.java:2651)
        at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2630)
        at org.jboss.threads.EnhancedQueueExecutor.runThreadBody(EnhancedQueueExecutor.java:1622)
        at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1589)
        at java.base/java.lang.Thread.run(Thread.java:1583)
        at org.jboss.threads.JBossThread.run(JBossThread.java:501)
    Caused by: java.lang.NoClassDefFoundError: com/fasterxml/jackson/annotation/JsonSerializeAs

But using the brand new Vaadin 25.1.0 works! So I guess we will try to update directly to 25.1.0

[F-Kamp]

I would first recommend updating to the latest Vaadin 25.0 version, since a bug in License Checker preventing offline keys from being read from system properties and env variables was fixed.

About using property, I'm not a Gradle user/expert, but License Checker expects a system property (-Dvaadin.offlineKey) not a Gradle property. IIRC Gradle does not propagate system properties from the CLI to the tasks, nor it converts Gradle properties to system properties.

And regarding the system/Gradle properies: The license documentation uses -P arguments for Gradle when passing the commercialWithBanner property:

./gradlew build -Pvaadin.productionBuild -Pvaadin.commercialWithBanner

Sadly there is no example how to pass the offline key when using Gradle.

Since I'm no expert on Gradle either, I used the environment variable approach instead.

[mcollovati]

vaadin.commercialWithBanner is indeed a Vaadin Gradle plugin property, but vaadin.offlineKey is not. The last one is a system property handled only by the License Checker artifact.

Actually, I don't know if system property is never available to the Vaadin build process in Gradle projects, or if this is only related to how the Gradle build is configured or if it has to do with the Quarkus build process.

[mcollovati]

In your example project, adding the following to allprojects section, seems to work.
But I'm 100% sure there is a better way to do this, configuring only the project/task that performs the build

    System.getProperty("vaadin.offlineKey")?.let { key ->
        tasks.configureEach {
            System.setProperty("vaadin.offlineKey", key)
        }
    }

[F-Kamp]

I see. So not really a bug, just a limitation of the License Checker.

Adding a bit more information about how to pass the offlineKey in Gradle multi module projects here might be helpful.

[mcollovati]

So not really a bug, just a limitation of the License Checker.

Actually, I couldn't say it is a limitation of License Checker, since it correctly handles environment variables and system properties.
I see it more as a constraint of the build tool that should be properly configured to propagate system properties into tasks execution.

Anyway, documentation could be improved in this regard by mentioning the Gradle limitation/feature and potentially providing some hints on how to work around it.

I'll reopen this issue as a documentation improvement request