Skip to content

Question: CI configuration? #514

@xfbs

Description

@xfbs

Hey!

So, I made the PR for #512. I saw that the CI is testing Windows and macOS targets. I fixed my PR to make those checks pass, however that made me think: does it even make sense that we test for Windows and macOS targets? In my understanding, unlike coreutils/binutils, the util-linux tools are all specific to Linux (eg: make syscalls that are Linux-only) and are not designed to be portable. Checking that they compile on Windows/macOS does not add much value (usually just means we need cfg blocks to disable things).

I feel like checking if they will build on macOS and Windows adds little value. However, what might add more value is having checks for different architectures on Linux, specifically:

  • x86_64-unknown-linux-gnu
  • x86_64-unknown-linux-musl
  • riscv64gc-unknown-linux-gnu
  • riscv64gc-unknown-linux-musl
  • aarch64-unknown-linux-gnu
  • aarch64-unknown-linux-musl
  • i686-unknown-linux-gnu (maybe, if we care about 32-bit)
  • i686-unknown-linux-musl (maybe, if we care about 32-bit)

I feel like we should make sure that the tools compile and work on these.

What is your take on this?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions