-
Notifications
You must be signed in to change notification settings - Fork 1
Definition of host parameter #19
Description
We have multiple ways to define the host-parameter: the param-default value, the class-paramters, passed to the plugin-manager and the environment variable.
In the current implementation, the parmeters from the plugin-manager are completly ignored (which is not good. currently I'm fiddeling around with environment variables in concert, since I can not define it in the constructor).
Currently https://github.com/ufo-kit/uca-net/blob/master/uca-net-camera.c#L618 reads the environment variable and depending on its exitence sets the host property to its value or to "localhost".
Now the question: Which configuration should be stronger?
I would suggest that a set paramter via the plugin-manager should not be overwritten from an environment-variable. If it isnot set via the manager we check the environment variable and if both are not set we set it to localhost.
Why should we set it to localhost as default? The only use-case is for running local tests.