1.0 functional release meta

[trycatchal]

ALL THE BELOW NEED PRS AGAINST THE functional-only BRANCH :) and they're already prioritized in order

• 1. tests for HTPipeAttachData along with its todos
• 2. branch off previous item... HTPipeAttachData DX todo
• 3. subclassers.ts and mongoose.ts rewrite for functional
• 4. 1.0 functional release meta #21 (comment)
• 5. branch off subclassers-and-mongoose-refactor: port OOP changes over to functional (see NOT FOR MERGE: OOP-hipthrusts changes to port to functional-hipthrusts #27)
• 7. Implement all other HTPipe*s along with HTPipe itself
• 8. do hipExpressHandlerFactory tests to give time for review of other branches
• 9. Move WB codebase over and verify javascript side \o/
• 10. Rename anything that sounds OOey - e.g. "subclassers" - they're not subclassers anymore
• 11. Revive all those commented out tests (the zelda ones) in new functional versions
• 12. Left-over changes from OO branch: 1.0 functional release meta #21 (comment)
• 13. give time for review with missing HTPipe* tests and HTPipe itself's test
• 13a. Replacing all the types with their IntersectProperties variants
• 13b. withDefaultImplementations: implementation, call, and removing all the complexity from executeHipThrustable along with its signature change
  (not sure which order is optimal - maybe both at once in one branch)
• 14. todos in executeHipThrustable
• 15. LOW PRIORITY todo in types.ts object-like / object-like or booly constraints type safety
• 16. LOW PRIORITY HasInitPreContext todo
• 17. LOW PRIORITY remove all forceful typing where typescript already knows how to infer it - e.g. WithInit's return value. Lots of that was necessary because of the OO stuff but isn't necessary anymore. Make sure we have test coverage to ensure the types aren't broken when doing this.

[trycatchal]

before we move on from HTPipeAttachData, one more little fix...
left: (context: {a: number}) => {b: string}
right: (context: {b: string}) => {b: number}
should become
{a: number} => {b: number}
I think the fix is to make the return type of the first overload TRightOut & Omit<TLeftOut, keyof or something

• fix and test for ^

[trycatchal]

Missing updates from OO:

1. refactor mongoose-specific operators to use general-purpose ones (e.g. WithParamsSanitized, WithSaveOnDocument, WithUpdateDocument, WithBodySanitized, WithResponseSanitized, etc. use WithDoWork, etc - like WithPojoToDocument does)
2. WithResponseFunctional - still has functional in name

[VolodymyrWork23]

initPreContext optional everywhere like the sanitizers

• initPreContext optional

[VolodymyrWork23]

https://github.com/captaincaius/hipthrusts/pull/49/files#diff-22d221739f9dc3ffd50b561c1f3c1fb7L3

• Global namespace pollution shouldn't be allowed at all! Let alone, pollution ACROSS FILES! imports like this shouldn't be allowed at all! After a quick search I didn't find a tsconfig way to make it illegal, but I found tslint's "no-import-side-effect". I'm not sure if it's exactly what we want though.

• make it illegal and verify our solution solves the problem

• We should be making circle confirm that we can do a successful build through npm build too

• update CI config so "npm build" failure is needed too

• tsconfig.json is used by vscode - but that's our TEST tsconfig. Instead, that file should be renamed to tsconfig.base.json, and tsconfig.build.json should be renamed to tsconfig.json, and we need a new tsconfig.test.json (which test should use)

• reorganize, fix, and clean up tsconfig stuff

• We should avoid the name "context" just in case from now on - htCtx instead maybe

• rename generic names like "context" everywhere

[trycatchal]

from chat...

• refactor tests with a function that tests functionality AND types like so...

HTPipeTest<
  TPipe extends Optionally*&,
  TPipeIn,
  TPipeOut,
  TValid = TBlah extends blah ? TBlah2 extends blah ? ... ? true : never : never : never ... : never,
  TPipeInExpected = TPipeIn,
  TPipeOutExpected = TPipeOut
>(pipe: TPipe, stage: 'attachData' | 'preAuthorize' ... , pipeIn: TPipeIn, pipeOut: TPipeOut, valid: TValid = true);

So if TPipeInExpected has too few or too many properties, or wrong types, TValid will become never, and the invocation of the function will say "true does not extend never" or something.

Also... we should TEST THE TEST to make sure it never regresses and gives us a false sense of security via a few //ts-expect-error'ed calls to it where valid is never.

[trycatchal]

• minor: for clarity, BlahContextOut types should become BlahReturn, and BlahContextOutObject should become BlahContextOut

[VolodymyrWork23]

https://github.com/captaincaius/hipthrusts/pull/48/files#diff-f41e9d04a45c83f3b6f6e630f10117feR725 needs to be right.InitPreContext
also we need to verify that we didn't missed any other same mistakes

• fix and verify

[trycatchal]

• HTPipe authorizers lose left context returned #37 should also block 1.0

[trycatchal]

• add test coverage for multi-stage operators
• also need a todo for adding test coverage for weird operators that can return bool or void (e.g. authorizers and doWork)
• also todo for testing stages that do NOT snowball context (e.g. sanitizers and respond)
• HTPipe todos/fixmes including making the automatic-type-guessing overloads snowball context from all prior stages

[trycatchal]

• remove all OO residue that already has a functional equivalent - what ever doesn't have functional equivalents, identify it and see if it has any remaining value

[trycatchal]

• update README to remove all OO stuff

[trycatchal]

• I'm not sure I like the With___ prefix anymore - it doesn't really make sense now that we've abandoned the OO stuff - maybe just AttachData(), DoWork(), SanitizeBody(), ...
  THAT probably should block 1.0 since it'll break compatibility (unless we leave residue for a completely unused library :D)

The next thing shouldn't necessarily block 1.0 functional release, but maybe 1.2 ...

• Bring back convenience wrappers like With___From (instead of context, passes a specified member of context to pass), With___To (returns {key: retval}), and With___FromTo (does both).