Temporary file is not deleted in case of error

[elvvis]

If an error occurs while writing the xlsx file, the temporary .tmp file will not be deleted.

[aral-matrix]

Could you be more specific as to what kind of error you had? This behaviour is actually desirable in some situations - for example when you have file system permission errors - it's arguably better to have the tmp file, than potentially lose the generated file. Also, to be able to potentially analyze the file contents.

[elvvis]

In my case, I edit and save an existing Excel file. However, if this file is open in Excel, a writing error occurs when saving.

[aral-matrix]

Thank you for the quick response - my late one was due to vacation absence, sorry for that.

I would agree that your use-case is undesirable & I will add this to the feature list. I have two potential implementations in mind:

1. throw an exception that includes in the exception class info the name of the temporary file generated, so that the user can decide themselves what to do with it
2. change the function XLDocument::saveAs (or add an overload) from

void XLDocument::saveAs(const std::string& fileName, bool forceOverwrite);

to

void XLDocument::saveAs(const std::string& fileName, int saveFlags);

so that it can be called as

doc.saveAs( "filename.xlsx", XLOverwrite | XLDeleteTempfile );

Possibly, I might implement both. Unfortunately, I am still stuck on some major CMake changes (ironic to have a productivity killer in the build environment rather than being able to work on features :() so this issue will likely remain open for quite some time. My apologies in advance.

[elvvis]

That's no problem at all, the main thing is that there is a solution.
I prefer the second option, I find it more elegant.