-
Notifications
You must be signed in to change notification settings - Fork 20
Deprecate finalize_model_tidyclust() and finalize_workflow_tidyclust() #223
Copy link
Copy link
Open
Labels
upkeepmaintenance, infrastructure, and similarmaintenance, infrastructure, and similar
Description
finalize_model_tidyclust() and finalize_workflow_tidyclust() are now fully redundant — tune's own versions already support cluster_spec natively.
Specifically:
tune::finalize_model()explicitly checksinherits(x, "cluster_spec")in its guard condition, so it already handles tidyclust models.tune::finalize_workflow()callsfinalize_model()internally, so it also works with cluster specs automatically.
Steps
- Verify that
tune::finalize_model()andtune::finalize_workflow()produce identical results to the tidyclust versions forcluster_specobjects. - Deprecate
finalize_model_tidyclust()andfinalize_workflow_tidyclust()using the lifecycle package, pointing users to the tune equivalents. - Remove the deprecated functions in a future breaking release.
Note
This is a breaking change for any users calling finalize_model_tidyclust() or finalize_workflow_tidyclust() directly. The deprecation period allows them to migrate to tune::finalize_model() and tune::finalize_workflow().
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
upkeepmaintenance, infrastructure, and similarmaintenance, infrastructure, and similar