Skip to content

Refactor button properties #171

@devmount

Description

@devmount

We currently use a type property for different button styles, which can be easily confused with the native button type prop.

Proposal:

  • Change the type prop to be exactly like the native button type
  • Change the variant prop (former type) to reflect the button flavor (primary, secondary, etc)
  • Add outline prop (former variant) as boolean if the button is rendered as outline only

This would be much more intuitive for devs.

Originally posted by @devmount in #168 (comment)

Metadata

Metadata

Assignees

Labels

BREAKINGThis issue or PR contains a breaking change which requires a new major release.enhancementNew feature or request

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions