From c6a3e5966a3145b660a3cb269183932f973e128d Mon Sep 17 00:00:00 2001 From: Jonathan Leitschuh Date: Sat, 19 Nov 2022 02:59:34 +0000 Subject: [PATCH] vuln-fix: Temporary File Information Disclosure This fixes temporary file information disclosure vulnerability due to the use of the vulnerable `File.createTempFile()` method. The vulnerability is fixed by using the `Files.createTempFile()` method which sets the correct posix permissions. Weakness: CWE-377: Insecure Temporary File Severity: Medium CVSSS: 5.5 Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.SecureTempFileCreation) Reported-by: Jonathan Leitschuh Signed-off-by: Jonathan Leitschuh Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/18 Co-authored-by: Moderne --- src/test/java/com/tamingtext/mahout/VectorExamplesTest.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/test/java/com/tamingtext/mahout/VectorExamplesTest.java b/src/test/java/com/tamingtext/mahout/VectorExamplesTest.java index baaa93d..f005cf0 100644 --- a/src/test/java/com/tamingtext/mahout/VectorExamplesTest.java +++ b/src/test/java/com/tamingtext/mahout/VectorExamplesTest.java @@ -20,6 +20,7 @@ package com.tamingtext.mahout; import java.io.File; +import java.nio.file.Files; import java.util.ArrayList; import java.util.List; @@ -77,7 +78,7 @@ public void testProgrammatic() throws Exception { File tmpDir = new File(System.getProperty("java.io.tmpdir")); File tmpLoc = new File(tmpDir, "sfvwt"); tmpLoc.mkdirs(); - File tmpFile = File.createTempFile("sfvwt", ".dat", tmpLoc); + File tmpFile = Files.createTempFile(tmpLoc.toPath(), "sfvwt", ".dat").toFile(); Path path = new Path(tmpFile.getAbsolutePath()); Configuration conf = new Configuration();//