Just wanted to drop a heads up:
Your work on this repo has been hugely helpful to a project we're spinning up using automated control of some Neewer MS60 lights.
I made some minor edits to the getCorrectedName and getLightSpecs functions to allow for the script to recognize our MS60s, which was only appending the NW-... names to the newLightNames list and adding an "MS60 ... " entry to the masterNeewerLightList (full changes below).
If you want to integrate those specific changes to add this functionality I'm happy to make a pull request, but I didn't want to make work for you for just our niche specific lights. For now, because we have to have a way to let new users download the updated code without me passing along the edits manually so I'm just going to make a fork that has them (and any other specific niche models we want to make work). But I'm happy to have any of those changes be merged back in eventually if you'd prefer.
I'm also happy to brainstorm about ways to generalize the discovery and addition of new light names for users so that this can be handled on the fly rather than hassling you to update a master list! If you haven't already got a much better solution you're working on, in our case, the http server recognized and linked with the new lights just fine, but the commands to the light would not send. However just manually adding the appropriate entries in those two lists allowed at least the http server to drive the lights no problem. Maybe a helper function that allows users to add whatever "real name" the software discovers for their specific niche light along with a list of values required for the master light list (e.g. ["MS60", 5600, 5600, False, 1] in our case) that then becomes added into their own local repository of accepted corrected names. You would certainly know better than I in any case.
All best,
Astaroph
Specific changes:
added the following to the end of newLightNames in getCorrectedName in NeewerLite-Python.py:
,["NW-20230103&FFFFFFFF","MS60"],["NW-20230103&00000000","MS60"]
Added the following entry to masterNeewerLightList in getLightSpecs
["MS60", 5600, 5600, False, 1]
Just wanted to drop a heads up:
Your work on this repo has been hugely helpful to a project we're spinning up using automated control of some Neewer MS60 lights.
I made some minor edits to the getCorrectedName and getLightSpecs functions to allow for the script to recognize our MS60s, which was only appending the NW-... names to the newLightNames list and adding an "MS60 ... " entry to the masterNeewerLightList (full changes below).
If you want to integrate those specific changes to add this functionality I'm happy to make a pull request, but I didn't want to make work for you for just our niche specific lights. For now, because we have to have a way to let new users download the updated code without me passing along the edits manually so I'm just going to make a fork that has them (and any other specific niche models we want to make work). But I'm happy to have any of those changes be merged back in eventually if you'd prefer.
I'm also happy to brainstorm about ways to generalize the discovery and addition of new light names for users so that this can be handled on the fly rather than hassling you to update a master list! If you haven't already got a much better solution you're working on, in our case, the http server recognized and linked with the new lights just fine, but the commands to the light would not send. However just manually adding the appropriate entries in those two lists allowed at least the http server to drive the lights no problem. Maybe a helper function that allows users to add whatever "real name" the software discovers for their specific niche light along with a list of values required for the master light list (e.g. ["MS60", 5600, 5600, False, 1] in our case) that then becomes added into their own local repository of accepted corrected names. You would certainly know better than I in any case.
All best,
Astaroph
Specific changes:
added the following to the end of newLightNames in getCorrectedName in NeewerLite-Python.py:
,["NW-20230103&FFFFFFFF","MS60"],["NW-20230103&00000000","MS60"]
Added the following entry to masterNeewerLightList in getLightSpecs
["MS60", 5600, 5600, False, 1]