Skip to content

Rename NodeInfo's publicKey and nodePublicKey #245

@fboucquez

Description

@fboucquez

Regarding the names, I prefer names that are useful to the user, not based on where the property comes from.
For instance, I don't know if the user is familiar enough with the concept of Certificate Authority. Is this the key used for signing new blocks? Can we call it something like signingPublicKey or harvestingPublicKey?
Regarding nodePublicKey, this is also confusing, since all these keys are related to the node somehow. This is the key used to activate Delegated Harvesting, and it relates to TLS somehow, right? Can we call it something like communicationPublicKey, tlsPublicKey, transamissionPublicKey, networkPublicKey, ... ?

Originally posted by @segfaultxavi in #244 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions