-
Notifications
You must be signed in to change notification settings - Fork 6
Rename NodeInfo's publicKey and nodePublicKey #245
Copy link
Copy link
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Regarding the names, I prefer names that are useful to the user, not based on where the property comes from.
For instance, I don't know if the user is familiar enough with the concept of Certificate Authority. Is this the key used for signing new blocks? Can we call it something like signingPublicKey or harvestingPublicKey?
Regarding nodePublicKey, this is also confusing, since all these keys are related to the node somehow. This is the key used to activate Delegated Harvesting, and it relates to TLS somehow, right? Can we call it something like communicationPublicKey, tlsPublicKey, transamissionPublicKey, networkPublicKey, ... ?
Originally posted by @segfaultxavi in #244 (comment)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request