Naming scheme is inconsistent

[stellaaash]

Sometimes we use This_Case for classes, other times ThisCase.

We need to put down which we're using for which type exactly, because this is getting pretty ugly, fast.

[stellaaash]

Project Nomenclature

• All types (structs, classes, typedefs...) should be in PascalCase
• Variables stick to camel_case
• Files containing only functions are camel_case, while files containing class implementation or interfaces are PascalCase
• Abbreviations (especially in filenames) should be reduced to a minimum, unless it is really idiomatic this way (like i for iterator in a loop)

@0yech What do you think? Right now the project is really messy with names, I look to fix that. Let me know what you think about my proposal.

[0yech]

I'm fine with it, it's not too strict as it's just about being case-sensitive. Still got a couple questions though.

All types (structs, classes, typedefs...) should be in PascalCase

So we change f.e HTTP_Method for things like HttpMethod ? File_Path to FilePath ?

How does it apply to enums ? We should keep UPPER_CAMEL_CASE right ? (DIR_PATH, FILE_PATH) I think it fits enums better.

I would suggest making a renaming pull request after merging #36 File Manager. So we continue fresh.

You might want to check out github actions for CI workflows/checks. It will not do everything but it can check for compliance we enforce with clang-format/tidy. Unsure if it's really a good idea as it won't fix the main problem. But you'd probably like this.

[stellaaash]

So we change f.e HTTP_Method for things like HttpMethod ? File_Path to FilePath ?

Yes :3

How does it apply to enums ? We should keep UPPER_CAMEL_CASE right ? (DIR_PATH, FILE_PATH) I think it fits enums better.

Those are macros, we're keeping the SCREAMING_CASE for those. Enum names (the actual types) get PascalCase.

I would suggest making a renaming pull request after merging #36 File Manager. So we continue fresh.

Yeah I'm waiting on #36 before merging this. I'll rebase this branch on main once it's merged.

You might want to check out github actions for CI workflows/checks. It will not do everything but it can check for compliance we enforce with clang-format/tidy. Unsure if it's really a good idea as it won't fix the main problem. But you'd probably like this.

It's on my radar. It looks cool and would probably be useful, I just never got around to look into it.