Skip to content

Avoid false positives in TypeChecker for falsey config values #120

@javihgil

Description

@javihgil

Problem

TypeChecker uses empty() when comparing stored version options against configured options.

Current code:

  • src/Helper/TypeChecker.php:34 treats the configured option as missing when it is falsey

Impact

This creates false positives for legitimate values such as:

  • 0
  • false
  • ''

As a result, versions can be reported as changed even when database and configuration values actually match.

Expected behavior

  • compare option presence with array_key_exists() or equivalent
  • only mark an option as changed when the key is missing or the values are genuinely different
  • add tests covering falsey config values

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions