Skip to content

SIGFPE if dps_plot_points < 6 #11287

@0xjc

Description

@0xjc

Describe the bug

SIGFPE in print_html_player_plots if using dps_plot_stat with dps_plot_points < 6.

Expected behavior

No crash

To Reproduce

Add to any sim with html report

dps_plot_stat=crit
dps_plot_step=1000
dps_plot_points=5
dps_plot_iterations=1000

Additional information

  • SimulationCraft Version (required)
    trunk (b9cf995)

Stack trace:

Thread 1 "simc" received signal SIGFPE, Arithmetic exception.
0x0000555557893ac5 in (anonymous namespace)::print_html_player_plots (os=..., p=...) at /home/ubuntu/wow/simc/engine/report/report_html_player.cpp:3254
3254            if ( idx % rows == 0 )
(gdb) p rows
$1 = 0
(gdb) bt
#0  0x0000555557893ac5 in (anonymous namespace)::print_html_player_plots (os=..., p=...) at /home/ubuntu/wow/simc/engine/report/report_html_player.cpp:3254
#1  0x00005555578b198c in (anonymous namespace)::print_html_player_ (p=..., os=...) at /home/ubuntu/wow/simc/engine/report/report_html_player.cpp:4954
#2  report::print_html_player (os=..., p=...) at /home/ubuntu/wow/simc/engine/report/report_html_player.cpp:5029
#3  0x000055555787c8b1 in (anonymous namespace)::print_html_ (sim=..., os=...) at /home/ubuntu/wow/simc/engine/report/report_html_sim.cpp:1236
#4  report::print_html (sim=...) at /home/ubuntu/wow/simc/engine/report/report_html_sim.cpp:1360
#5  0x0000555557726960 in report::print_suite (sim=sim@entry=0x7fffffffc710) at /home/ubuntu/wow/simc/engine/report/reports.cpp:259
#6  0x0000555556f2cafd in sim_t::main (this=this@entry=0x7fffffffc710, args=std::vector of length 1, capacity 1 = {...}) at /home/ubuntu/wow/simc/engine/sc_main.cpp:368
#7  0x0000555556f2cca7 in main (argc=2, argv=0x7fffffffdf28) at /home/ubuntu/wow/simc/engine/sc_main.cpp:408

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions