Skip to content

It must be easier to use CtrlPPcheck for single file without providing tons of options #105

@hfrmobile

Description

@hfrmobile

C:\WinCCOA_Proj\_Subs\WinCCOA_QualityChecks\bin\ctrlppcheck\ctrlppcheck SecurityEvents.ctl --winccoa-projectName=DEVharry_320

reports the following:

Checking SecurityEvents.ctl cfgname: ...
(error) There is no rule to execute. Tokenlist: raw
[SecurityEvents.ctl:52]: (information) Void function without void return type.
[SecurityEvents.ctl:57]: (information) Void function without void return type.
[SecurityEvents.ctl:107]: (information) Void function without void return type.
[SecurityEvents.ctl:118]: (information) Void function without void return type.
[SecurityEvents.ctl:188]: (information) Void function without void return type.
[SecurityEvents.ctl:210]: (information) Void function without void return type.
[SecurityEvents.ctl:218]: (information) Void function without void return type.
cppcheck: warning: custom naming rule file is not specified or does not exist
cppcheck: naming check: standard rule file path =  C:\WinCCOA_Proj\_Subs\WinCCOA_QualityChecks\bin\ctrlppcheck\../../data/ctrlPpCheck/rule/variableNaming.xml
[SecurityEvents.ctl:85]: (warning) Undefined variable: DATA_REL_PATH
[SecurityEvents.ctl:93]: (warning) Undefined variable: PRIO_INFO
[SecurityEvents.ctl:93]: (warning) Undefined variable: ERR_PARAM
[SecurityEvents.ctl:103]: (warning) Undefined variable: PRIO_SEVERE
[SecurityEvents.ctl:103]: (warning) Undefined variable: ERR_PARAM
[SecurityEvents.ctl:133]: (warning) Undefined variable: DATA_REL_PATH
[SecurityEvents.ctl:133]: (warning) Undefined variable: SEARCH_PATH_LEN
[SecurityEvents.ctl:138]: (warning) Undefined variable: DATA_REL_PATH
[SecurityEvents.ctl:183]: (warning) Undefined variable: PRIO_SEVERE
[SecurityEvents.ctl:183]: (warning) Undefined variable: ERR_PARAM
[SecurityEvents.ctl:194]: (warning) Undefined variable: PROJ
[SecurityEvents.ctl:195]: (warning) Undefined variable: SE_USER
[SecurityEvents.ctl:195]: (warning) Undefined variable: SE_PWD
[SecurityEvents.ctl:199]: (warning) Undefined variable: PROJ
[SecurityEvents.ctl:199]: (warning) Undefined variable: SE_USER
[SecurityEvents.ctl:199]: (warning) Undefined variable: SE_PWD
[SecurityEvents.ctl:201]: (warning) Undefined variable: LOG_REL_PATH
[SecurityEvents.ctl:203]: (warning) Undefined variable: F_OK
[SecurityEvents.ctl:222]: (warning) Undefined variable: XML_ELEMENT_NODE
[SecurityEvents.ctl:70]: (information, inconclusive) Uninitialized variable: jsSys
[SecurityEvents.ctl:77]: (information, inconclusive) Uninitialized variable: jsProj
[SecurityEvents.ctl:161]: (information, inconclusive) Uninitialized variable: mergedSe
[SecurityEvents.ctl:164]: (information, inconclusive) Uninitialized variable: mergedSe
[SecurityEvents.ctl:166]: (information, inconclusive) Uninitialized variable: mergedSe
[SecurityEvents.ctl:194]: (information, inconclusive) Uninitialized variable: host
[SecurityEvents.ctl:194]: (information, inconclusive) Uninitialized variable: port
[SecurityEvents.ctl:195]: (information, inconclusive) Uninitialized variable: ddsResult
(error) There is no rule to execute. Tokenlist: normal
(error) There is no rule to execute. Tokenlist: simple

But only relevant/real issues should be reported, which are:

Checking SecurityEvents.ctl cfgname: ...
[SecurityEvents.ctl:52]: (information) Void function without void return type.
[SecurityEvents.ctl:57]: (information) Void function without void return type.
[SecurityEvents.ctl:107]: (information) Void function without void return type.
[SecurityEvents.ctl:118]: (information) Void function without void return type.
[SecurityEvents.ctl:188]: (information) Void function without void return type.
[SecurityEvents.ctl:210]: (information) Void function without void return type.
[SecurityEvents.ctl:218]: (information) Void function without void return type.

Suggestions
"Well known" constants like DATA_REL_PATH, PRIO_INFO, ERR_PARAM etc. should be known by the tool by default without the need to provide config options/parameters.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions